Page MenuHomePhabricator
Create Task
Maniphest T354874

Allow MediaModeration extension to be used on postgres
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The MediaModeration extension tests currently fail for postgres and should be fixed to work on postgres. While this happening we should investigate whether the extension works for postgres and make necessary fixes to support it.

Details

SubjectRepoBranchLines +/-
tests: Call IDatabase::timestamp for fa_deleted_timestampmediawiki/extensions/MediaModerationmaster+12 -12
Use IDatabase::timestamp when selecting img_timestampmediawiki/extensions/MediaModerationmaster+20 -6
Customize query in gerrit

Event Timeline

Dreamy_Jazz created this task.Jan 11 2024, 2:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 11 2024, 2:57 PM
gerritbot added a comment.Jan 11 2024, 7:42 PM

Change 989914 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MediaModeration@master] tests: Call IDatbaase::timestamp for fa_deleted_timestamp

https://gerrit.wikimedia.org/r/989914

gerritbot added a project: Patch-For-Review.Jan 11 2024, 7:42 PM

Change 989915 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/MediaModeration@master] Use IDatbase::timestamp when selecting img_timestamp

https://gerrit.wikimedia.org/r/989915

Umherirrender subscribed.Jan 11 2024, 7:42 PM

On making the test pass on postgres I can help and have uploaded two patch sets.

gerritbot added a comment.Jan 11 2024, 11:13 PM

Change 989914 merged by jenkins-bot:

[mediawiki/extensions/MediaModeration@master] tests: Call IDatabase::timestamp for fa_deleted_timestamp

https://gerrit.wikimedia.org/r/989914

gerritbot added a comment.Jan 11 2024, 11:13 PM

Change 989915 merged by jenkins-bot:

[mediawiki/extensions/MediaModeration@master] Use IDatabase::timestamp when selecting img_timestamp

https://gerrit.wikimedia.org/r/989915

Umherirrender removed a project: Patch-For-Review.Jan 11 2024, 11:14 PM
Umherirrender unsubscribed.
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.14; 2024-01-16).Jan 12 2024, 1:00 AM
kostajh moved this task from MediaModeration 2.0 to MediaModeration 2.1 on the MediaModeration board.Jan 31 2024, 9:44 AM
kostajh edited projects, added MediaModeration (MediaModeration 2.1); removed MediaModeration (MediaModeration 2.0).
Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)).Jan 31 2024, 1:07 PM

I think support should already be there, but I will quickly test. If I can't see anything broken I intend to resolve this ticket to save future time.

Dreamy_Jazz closed this task as Resolved.Jan 31 2024, 1:46 PM
Dreamy_Jazz claimed this task.
Dreamy_Jazz moved this task from Priority Backlog to Done on the Trust and Safety Product Sprint (Sprint Kazoo (Jan 29 - Feb 9 2024)) board.
Dreamy_Jazz set the point value for this task to 1.

Tested on a local postgres instance and didn't find anything that was broken. Marking this ticket as resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL