VisualEditor's foreign-resources.yaml contains invalid SPDX license constructs
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Jan 13 2024, 6:47 PM

Description

Following up on T330428: Validate SPDX licenses in foreign-resources.yaml using ForeignResourceManager/ForeignResourceStructureTest...

When playing with https://gerrit.wikimedia.org/r/c/mediawiki/core/+/955998 for T330508: Expand running of ForeignResourceStructureTest against skins and extensions that have foreign-resources.yaml files, we see these failures:

18:38:28 5) ForeignResourceStructureTest::testVerifyIntegrity with data set #5 ('/workspace/src/extensions/Vis...or/lib')
18:38:28 ... verifying 'Color Picker'
18:38:28 ... Color Picker is documentation-only, skipping
18:38:28 ... verifying 'Diff Match and Patch'
18:38:28 ... Diff Match and Patch is documentation-only, skipping
18:38:28 ... verifying 'DOMPurify'
18:38:28 Module 'DOMPurify' has an invalid SPDX license identifier 'Apache-2.0 AND MPLv2', see <https://spdx.org/licenses/>... DOMPurify is documentation-only, skipping
18:38:28 ... verifying 'jsdifflib'
18:38:28 ... jsdifflib is documentation-only, skipping
18:38:28 ... verifying 'PapaParse'
18:38:28 ... PapaParse is documentation-only, skipping
18:38:28 ... verifying 'RangeFix'
18:38:28 ... RangeFix is documentation-only, skipping
18:38:28 ... verifying 'socket.io-client'
18:38:28 ... socket.io-client is documentation-only, skipping
18:38:28 ... verifying 'spark-md5'
18:38:28 Module 'spark-md5' has an invalid SPDX license identifier 'BSD-3-Clause AND WTFv2', see <https://spdx.org/licenses/>... spark-md5 is documentation-only, skipping
18:38:28 ... verifying 'Tree Differ'
18:38:28 ... Tree Differ is documentation-only, skipping
18:38:28 ... verifying 'Universal Language Selector data'
18:38:28 Module 'Universal Language Selector data' has an invalid SPDX license identifier 'MIT AND GPLv2', see <https://spdx.org/licenses/>... Universal Language Selector data is documentation-only, skipping
18:38:28 ... verifying 'VisualEditor'
18:38:28 ... VisualEditor is documentation-only, skipping

Details

	Subject	Repo	Branch	Lines +/-
	foreign-resources.yaml: Fix SPDX licenses	mediawiki/extensions/VisualEditor	master	+3 -3
	foreign-resources.yaml: Fix SPDX licenses	mediawiki/extensions/VisualEditor	REL1_41	+3 -3

Customize query in gerrit

Related Objects

Mentioned Here: T330428: Validate SPDX licenses in foreign-resources.yaml using ForeignResourceManager/ForeignResourceStructureTest
T330508: Expand running of ForeignResourceStructureTest against skins and extensions that have foreign-resources.yaml files

Event Timeline

Reedy created this task.Jan 13 2024, 6:47 PM

Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptJan 13 2024, 6:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Reedy triaged this task as Low priority.Jan 13 2024, 6:47 PM

Reedy renamed this task from ForeignResourceManager::validateLicense() does not support multiple licenses to ForeignResourceManager::validateLicense() does not like our usages of multiple licenses.Jan 13 2024, 6:50 PM

Reedy added projects: Technical-Debt, Software-Licensing.Jan 13 2024, 6:53 PM

Change 990348 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/VisualEditor@master] foreign-resources.yaml: Fix license for spark-md5

https://gerrit.wikimedia.org/r/990348

gerritbot added a project: Patch-For-Review.Jan 13 2024, 6:57 PM

Reedy renamed this task from ForeignResourceManager::validateLicense() does not like our usages of multiple licenses to VisualEditor's foreign-resources.yaml contains invalid SPDX license constructs.Jan 13 2024, 7:19 PM

Reedy edited projects, added VisualEditor; removed MediaWiki-Platform-Team, MediaWiki-ResourceLoader.

Change 990348 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] foreign-resources.yaml: Fix SPDX licenses

https://gerrit.wikimedia.org/r/990348

Change 990625 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/VisualEditor@REL1_41] foreign-resources.yaml: Fix SPDX licenses

https://gerrit.wikimedia.org/r/990625

Reedy closed this task as Resolved.Jan 15 2024, 7:17 PM

Reedy claimed this task.

Change 990625 merged by jenkins-bot: