Page MenuHomePhabricator

Comment-not-found notification not showing when following a permalink to a removed comment if permalinks frontend disabled
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
Nothing visibly. A suppressed exception is in the console: jQuery.Deferred exception: Cannot read properties of undefined (reading 'discussiontoolsfindcomment') TypeError: Cannot read properties of undefined (reading 'discussiontoolsfindcomment')

What should have happened instead?:
A toast should have appeared, saying that the comment couldn't be found:

image.png (160×566 px, 17 KB)

(From beta.)

Event Timeline

Change 989565 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@master] Comment-not-found toast not showing when enablePermalinksFrontend==false

https://gerrit.wikimedia.org/r/989565

Change 989565 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Comment-not-found toast not showing when enablePermalinksFrontend==false

https://gerrit.wikimedia.org/r/989565

ppelberg subscribed.

This issue is effectively resolved seeing as how it only existed in the ephemeral state where permalinks were not available by default at all wikis.