Page MenuHomePhabricator

wmf-checks-api: Gerrit checks display lists "merge failed" as success
Closed, ResolvedPublic

Event Timeline

Self note, the raw message is:

{
  "id": "6f5ef26bd9e7d0490c37e499195c44d49a9284d9",
  "tag": "autogenerated:ci-test",
  "author": {
    "_account_id": 75,
    "name": "jenkins-bot",
    "username": "jenkins-bot",
    "tags": [
      "SERVICE_USER"
    ]
  },
  "real_author": {
    "_account_id": 75,
    "name": "jenkins-bot",
    "username": "jenkins-bot",
    "tags": [
      "SERVICE_USER"
    ]
  },
  "date": "2024-02-05 15:00:26.000000000",
  "message": "Patch Set 2: Verified-1\\n\\nMerge Failed.\\n\\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.",
  "accounts_in_message": [],
  "_revision_number": 2,
  "_index": 3,
  "expanded": true,
  "commentThreads": [],
  "isImportant": true
}
hashar renamed this task from Gerrit checks display lists "merge failed" as success to wmf-checks-api: Gerrit checks display lists "merge failed" as success.Feb 5 2024, 3:34 PM

Change 997889 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@deploy/wmf/stable-3.7] wm-checks-api: handle Zuul 'Merge failed' messages

https://gerrit.wikimedia.org/r/997889

Change 997889 merged by jenkins-bot:

[operations/software/gerrit@deploy/wmf/stable-3.7] wm-checks-api: handle Zuul 'Merge failed' messages

https://gerrit.wikimedia.org/r/997889

Mentioned in SAL (#wikimedia-operations) [2024-02-06T14:54:24Z] <hashar@deploy2002> Started deploy [gerrit/gerrit@2e441ac]: wm-checks-api: handle Zuul 'Merge failed' messages - T356647

Mentioned in SAL (#wikimedia-operations) [2024-02-06T14:54:31Z] <hashar@deploy2002> Finished deploy [gerrit/gerrit@2e441ac]: wm-checks-api: handle Zuul 'Merge failed' messages - T356647 (duration: 00m 07s)

hashar claimed this task.

Thank you for having filed the task. There was a TODO comment left in the code from the first pass I have made back in ~ December 2022. I have made the code to hand the merge failure as a job failure and reported at ERROR level ;)