Page MenuHomePhabricator
Create Task
Maniphest T356730

Open links in a new tab, if $wgExternalLinkTarget = '_blank'
Closed, ResolvedPublicFeature
Actions

Description

Open links in a new tab, if $wgExternalLinkTarget = '_blank'.

Details

SubjectRepoBranchLines +/-
Set target to $wgExternalLinkTargetmediawiki/extensions/ImageMapREL1_39+4 -4
Set target to $wgExternalLinkTargetmediawiki/extensions/ImageMapmaster+28 -8
Customize query in gerrit

Related Objects

Event Timeline

alex-mashin created this task.Feb 6 2024, 3:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2024, 3:34 AM
gerritbot added a comment.Feb 6 2024, 5:51 AM

Change 997635 had a related patch set uploaded (by Alex Mashin; author: Alexander Mashin):

[mediawiki/extensions/ImageMap@master] Set target to $wgExternalLinkTarget

https://gerrit.wikimedia.org/r/997635

gerritbot added a project: Patch-For-Review.Feb 6 2024, 5:51 AM
alex-mashin changed the task status from Open to In Progress.Feb 6 2024, 6:04 AM
alex-mashin claimed this task.
gerritbot added a comment.Feb 7 2024, 9:32 AM

Change 997635 merged by jenkins-bot:

[mediawiki/extensions/ImageMap@master] Set target to $wgExternalLinkTarget

https://gerrit.wikimedia.org/r/997635

alex-mashin closed this task as Resolved.Feb 7 2024, 10:24 AM
alex-mashin removed a project: Patch-For-Review.
gerritbot added a comment.Feb 14 2024, 7:19 PM

Change 1003468 had a related patch set uploaded (by Yaron Koren; author: Alexander Mashin):

[mediawiki/extensions/ImageMap@REL1_39] Set target to $wgExternalLinkTarget

https://gerrit.wikimedia.org/r/1003468

gerritbot added a project: Patch-For-Review.Feb 14 2024, 7:19 PM
gerritbot added a comment.Feb 15 2024, 2:04 AM

Change 1003468 merged by jenkins-bot:

[mediawiki/extensions/ImageMap@REL1_39] Set target to $wgExternalLinkTarget

https://gerrit.wikimedia.org/r/1003468

Maintenance_bot removed a project: Patch-For-Review.Feb 15 2024, 2:30 AM
Lucas_Werkmeister_WMDE mentioned this in T357668: TypeError: Argument 1 passed to MediaWiki\Parser\Sanitizer::encodeAttribute() must be of the type string, null given, called in /srv/mediawiki/php-1.42.0-wmf.18/includes/xml/Xml.php on line 81.Feb 15 2024, 2:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL