Page MenuHomePhabricator
Create Task
Maniphest T357068

Do Not Export ZObjectKeyFactory from schema.js
Closed, ResolvedPublic
Actions

Description

Description

The class was moved to utils.js, so downstream consumers should require() it from there.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • all consumers require ZObjectKeyFactory from utils.js
    • function-orchestrator
    • function-schemata
  • schema.js stops exporting it
  • Pull-throughs complete

Remove all the non-applicable tags from the "Tags" field, leave only the tags of the projects/repositories related to this task

Completion checklist

Details

SubjectRepoBranchLines +/-
Update function-schemata sub-module to HEAD (97ea4cd)mediawiki/extensions/WikiLambdamaster+5 -5
wikifunctions: Upgrade orchestrator from 2024-02-26-150614 to 2024-03-05-140533operations/deployment-chartsmaster+1 -1
wikifunctions: Upgrade orchestrator from 2024-02-12-155846 to 2024-02-22-165335operations/deployment-chartsmaster+1 -1
wikifunctions: Upgrade evaluators from 2024-02-12-160222 to 2024-02-26-150300operations/deployment-chartsmaster+2 -2
wikifunctions: Upgrade orchestrator from 2024-02-12-155846 to 2024-02-26-150614operations/deployment-chartsmaster+1 -1
Customize query in gerrit
TitleReferenceAuthorSource BranchDest Branch
Update function-schemata sub-module to HEAD (04c5c89)repos/abstract-wiki/wikifunctions/wikilambda-cli!32jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (04c5c89)repos/abstract-wiki/wikifunctions/function-evaluator!171jforrestersync-function-schematamain
Update function-schemata sub-module to HEAD (04c5c89)repos/abstract-wiki/wikifunctions/function-orchestrator!137jforrestersync-function-schematamain
[BREAKING CHANGE] Drop ZObjectKeyFactory from schemarepos/abstract-wiki/wikifunctions/function-schemata!93jforresterT357068main
utils: Use ZObjectKeyFactory from schemata's utils.js, not normalize.jsrepos/abstract-wiki/wikifunctions/function-orchestrator!135jforresterT357068main
Customize query in GitLab

Event Timeline

cmassaro created this task.Feb 8 2024, 9:54 PM
Jdforrester-WMF added a project: Abstract Wikipedia Fix-It tasks.Feb 9 2024, 5:44 PM
CodeReviewBot added a project: Patch-For-Review.Feb 12 2024, 9:28 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/135

utils: Use ZObjectKeyFactory from schemata's utils.js, not normalize.js

Jdforrester-WMF changed the task status from Open to In Progress.Feb 12 2024, 9:29 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF triaged this task as Low priority.
Jdforrester-WMF updated the task description. (Show Details)
CodeReviewBot added a comment.Feb 14 2024, 9:10 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/135

utils: Use ZObjectKeyFactory from schemata's utils.js, not normalize.js

Maintenance_bot removed a project: Patch-For-Review.Feb 14 2024, 9:30 PM
CodeReviewBot added a project: Patch-For-Review.Feb 14 2024, 9:41 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/93

Migrate uses of ZObjectKeyFactory from schema to utils

Jdforrester-WMF updated the task description. (Show Details)Feb 14 2024, 9:41 PM
Mcastro moved this task from To triage to In Progress on the Abstract Wikipedia team board.Feb 15 2024, 5:37 PM
CodeReviewBot added a comment.Feb 20 2024, 3:21 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-schemata/-/merge_requests/93

[BREAKING CHANGE] Drop ZObjectKeyFactory from schema

Maintenance_bot removed a project: Patch-For-Review.Feb 20 2024, 3:31 PM
gerritbot added a comment.Feb 22 2024, 9:35 PM

Change 1005843 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-02-12-155846 to 2024-02-22-165335

https://gerrit.wikimedia.org/r/1005843

gerritbot added a project: Patch-For-Review.Feb 22 2024, 9:35 PM
gerritbot added a comment.Feb 22 2024, 10:55 PM

Change 1002570 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (dd1f3f4)

https://gerrit.wikimedia.org/r/1002570

CodeReviewBot added a comment.Feb 22 2024, 10:56 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/137

Update function-schemata sub-module to HEAD (dd1f3f4)

CodeReviewBot added a comment.Feb 22 2024, 10:57 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/171

Update function-schemata sub-module to HEAD (dd1f3f4)

CodeReviewBot added a comment.Feb 22 2024, 10:57 PM

jforrester opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/32

Update function-schemata sub-module to HEAD (dd1f3f4)

Jdforrester-WMF updated the task description. (Show Details)Feb 26 2024, 2:07 PM
CodeReviewBot added a comment.Feb 26 2024, 3:02 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-evaluator/-/merge_requests/171

Update function-schemata sub-module to HEAD (04c5c89)

gerritbot added a comment.Feb 28 2024, 3:12 PM

Change 1007351 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-02-12-155846 to 2024-02-26-150614

https://gerrit.wikimedia.org/r/1007351

gerritbot added a comment.Feb 28 2024, 3:13 PM

Change 1007351 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-02-12-155846 to 2024-02-26-150614

https://gerrit.wikimedia.org/r/1007351

gerritbot added a comment.Feb 28 2024, 3:17 PM

Change 1007353 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-02-12-160222 to 2024-02-26-150300

https://gerrit.wikimedia.org/r/1007353

gerritbot added a comment.Feb 28 2024, 3:21 PM

Change 1007353 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2024-02-12-160222 to 2024-02-26-150300

https://gerrit.wikimedia.org/r/1007353

gerritbot added a comment.Feb 28 2024, 3:27 PM

Change 1005843 abandoned by Jforrester:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-02-12-155846 to 2024-02-22-165335

Reason:

https://gerrit.wikimedia.org/r/1005843

CodeReviewBot added a comment.Mar 1 2024, 8:10 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/32

Update function-schemata sub-module to HEAD (04c5c89)

CodeReviewBot added a comment.Mar 1 2024, 8:15 PM

apine merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/137

Update function-schemata sub-module to HEAD (04c5c89)

gerritbot added a comment.Mar 5 2024, 2:44 PM

Change 1008874 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-02-26-150614 to 2024-03-05-140533

https://gerrit.wikimedia.org/r/1008874

gerritbot added a comment.Mar 5 2024, 7:59 PM

Change 1008874 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-02-26-150614 to 2024-03-05-140533

https://gerrit.wikimedia.org/r/1008874

gerritbot added a comment.Mar 5 2024, 8:34 PM

Change 1002570 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (97ea4cd)

https://gerrit.wikimedia.org/r/1002570

Maintenance_bot removed a project: Patch-For-Review.Mar 5 2024, 9:31 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.22; 2024-03-12).Mar 6 2024, 1:00 AM
Jdforrester-WMF closed this task as Resolved.Mar 13 2024, 2:37 PM
Jdforrester-WMF updated the task description. (Show Details)
Jdforrester-WMF moved this task from In Progress to Verify in production on the Abstract Wikipedia team board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL