Math CI tests are broken
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Physikerwelt
	Feb 17 2024, 11:31 PM

Description

Steps to replicate the issue (include links if applicable):

submit an empty change to the math extension

What happens?:

Test fail https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/1004312

00:28:55 1) MediaWiki\Extension\Math\Tests\PreferencesIntegrationTest::testMathOptionRegistered
00:28:55 InvalidArgumentException: Invalid username: 
00:28:55 
00:28:55 /workspace/src/extensions/CentralAuth/includes/User/CentralAuthUser.php:253
00:28:55 /workspace/src/extensions/CentralAuth/includes/User/CentralAuthUser.php:230
00:28:55 /workspace/src/extensions/CentralAuth/includes/CentralAuthHooks.php:141

What should have happened instead?:

test pass

Details

	Subject	Repo	Branch	Lines +/-
	PreferencesIntegrationTest: CA will fail on `null` User objects	mediawiki/extensions/Math	master	+1 -2

Customize query in gerrit

Related Objects

Mentioned Here: T357746: /wiki/Special:BlockList InvalidArgumentException: Invalid username

Event Timeline

Physikerwelt created this task.Feb 17 2024, 11:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 17 2024, 11:31 PM

Physikerwelt added a project: MediaWiki-extensions-CentralAuth.Feb 17 2024, 11:34 PM

Physikerwelt updated the task description. (Show Details)

Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptFeb 17 2024, 11:34 PM

It could be caused by the same problem as T357746. However I also don't understand the cause for T357746. A quick fix was to skip the test.

Change 1004621 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/Math@master] PreferencesIntegrationTest: Fix mock of `null` User object

https://gerrit.wikimedia.org/r/1004621

gerritbot added a project: Patch-For-Review.Feb 19 2024, 10:14 AM

@Physikerwelt, I was able to track down the issue here. In summary, it's because the mock will return a NULL user object which will break in CA on the onGetPreferences() hook run. I've made a patch to fix this.

DAlangi_WMF changed the task status from Open to In Progress.Feb 19 2024, 10:16 AM

DAlangi_WMF claimed this task.

DAlangi_WMF moved this task from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.

Change 1004621 merged by jenkins-bot:

[mediawiki/extensions/Math@master] PreferencesIntegrationTest: CA will fail on `null` User objects

https://gerrit.wikimedia.org/r/1004621

Maintenance_bot removed a project: Patch-For-Review.Feb 19 2024, 2:30 PM

This is now resolved. Math CI is no longer broken. See: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/1004309.

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.20; 2024-02-27).Feb 22 2024, 1:00 AM