Maniphest T358158

MultimediaViewer isn't opening when using Parsoid for Read Views
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Arlolra
	Feb 21 2024, 10:56 PM

Tags

Referenced Files

None

Subscribers

Description

The issue seems to be that $pageHasThumbnails = count( $out->getFileSearchOptions() ) > 0; is always false. Parsoid needs to call ContentMetadataCollector::addImage when parsing.

Details

	Subject	Repo	Branch	Lines +/-
	Bump wikimedia/parsoid to 0.19.0-a20	mediawiki/vendor	master	+206 -81
	Support "showmedia" parsertests option	mediawiki/services/parsoid	master	+29 -1
	Support "showmedia" parsertests option	mediawiki/core	master	+3 -0
	Bump wikimedia/parsoid to 0.19.0-a19	mediawiki/vendor	master	+461 -329
	Populate image metadata info in parser output	mediawiki/services/parsoid	master	+39 -9
	Return additional info about files in DataAccess	mediawiki/core	master	+2 -0

Customize query in gerrit

Event Timeline

Arlolra created this task.Feb 21 2024, 10:56 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 21 2024, 10:56 PM

Change 1005628 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Call ContentMetadataCollector::addImage

https://gerrit.wikimedia.org/r/1005628

Change 1005627 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] Return additional info about files in DataAccess

https://gerrit.wikimedia.org/r/1005627

Change 1005627 merged by jenkins-bot:

[mediawiki/core@master] Return additional info about files in DataAccess

https://gerrit.wikimedia.org/r/1005627

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.20; 2024-02-27).Feb 22 2024, 12:02 PM

ihurbain moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Feb 22 2024, 3:08 PM

Arlolra triaged this task as Medium priority.Feb 22 2024, 6:06 PM

Arlolra moved this task from Backlog to Code Review on the Content-Transform-Team-WIP board.

Change 1005836 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] Support "showmedia" parsertests option

https://gerrit.wikimedia.org/r/1005836

Change 1005837 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Support "showmedia" parsertests option

https://gerrit.wikimedia.org/r/1005837

Change 1005628 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Populate image metadata info in parser output

https://gerrit.wikimedia.org/r/1005628

Arlolra moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.Feb 22 2024, 10:05 PM

Change 1006201 had a related patch set uploaded (by Sbailey; author: Sbailey):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a19

https://gerrit.wikimedia.org/r/1006201

Change 1006201 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a19

https://gerrit.wikimedia.org/r/1006201

Post-deploy to group0 today, MultimediaViewer is opening on officewiki pages. It sometimes requires a purge.

Change 1005836 merged by jenkins-bot:

[mediawiki/core@master] Support "showmedia" parsertests option

https://gerrit.wikimedia.org/r/1005836

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.21; 2024-03-05); removed MW-1.42-notes (1.42.0-wmf.20; 2024-02-27).Feb 29 2024, 9:01 AM

Change 1005837 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Support "showmedia" parsertests option

https://gerrit.wikimedia.org/r/1005837

Maintenance_bot removed a project: Patch-For-Review.Feb 29 2024, 4:30 PM

Change 1008400 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a20

https://gerrit.wikimedia.org/r/1008400

gerritbot added a project: Patch-For-Review.Mar 4 2024, 9:30 AM

Change 1008400 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.19.0-a20

https://gerrit.wikimedia.org/r/1008400

Maintenance_bot removed a project: Patch-For-Review.Mar 4 2024, 4:32 PM