Page MenuHomePhabricator

wikibugs only shows milestone name without parent project name
Closed, ResolvedPublicBUG REPORT

Description

For example this was just sent to cloud-feed:

<+wikibugs> Cloud-VPS, DC-Ops, SRE, ops-eqiad, FY2023/2024-Q3-Q4: cloudcephosd1021-1034: hard drive sector errors increasing - https://phabricator.wikimedia.org/T348643#9582996 (dcaro)

cloud-services-team (FY2023/2024-Q3-Q4) is only shown as FY2023/2024-Q3-Q4 which is lacking most of the context.

Details

TitleReferenceAuthorSource BranchDest Branch
phorge: Construct fully qualified names for milestone projectstoolforge-repos/wikibugs2!8bd808work/bd808/debugging-toolsmain
Customize query in GitLab

Event Timeline

Sprint tags seem to be controversial in a number of ways:

Those tasks are all advocating for them to be ignored or shortened. This one is advocating for them to be longer. This probably will need a bit of thought and eventual discussion once the data available in the transaction is better understood.

Looks like the API is only grabbing the milestone name, instead of the full project name. Two examples below, their full names would be Wikibase Suite Team (Sprint-∞) & Release-Engineering-Team (Now this 🫠)

<+wikibugs> Release, Sprint-∞: Release WMDE.17 - (MediaWiki 1.41.0) - https://phabricator.wikimedia.org/T354644#9582876 (roti_WMDE)
<+wikibugs> Scap, Now this 🫠, Patch-For-Review: Scap backporting a patch that gets a -2 hangs - https://phabricator.wikimedia.org/T350628#9582225 (Sandeeps) Open→In progress
bd808 changed the subtype of this task from "Task" to "Bug Report".Feb 28 2024, 9:36 PM

We're experiencing something similar to this as well, but I don't know if I should make a new ticket for it.

We have a new IRC channel #wikimedia-data-platform
We have a Phabricator project called Data-Platform-SRE which uses milestones.

We added this configuration to wikibugs in channels.yaml:

"#wikimedia-data-platform":
    - Data-Platform-SRE(.*)?

We had expected that changes to the tasks within the milestones would be announced to this channel, but they are not.

Only tasks that are directly within the parent project are announced to the channel.

This would seem to be related to what @Peachey88 mentioned above:

Looks like the API is only grabbing the milestone name, instead of the full project name.

bd808 triaged this task as High priority.Feb 29 2024, 6:28 PM
bd808 moved this task from Backlog to Ready to Go on the Wikibugs board.

We're experiencing something similar to this as well, but I don't know if I should make a new ticket for it.

It does sound related. I would guess that the regression/change in project labels is happening across all of the project name related logic and not just in the final render. I think this task should be treated as a regression and not muddied by attempting to consider the incidentally related, long-standing issues I mentioned in T358653#9585576.

I'm now triaging this as high because of the report of what is functionally data loss (tasks not being announced in the expected channels).

bd808 changed the task status from Open to In Progress.Mar 3 2024, 5:49 PM
bd808 claimed this task.
bd808 moved this task from Ready to Go to Doing on the Wikibugs board.

Mentioned in SAL (#wikimedia-cloud) [2024-03-03T23:36:42Z] <wmbot~bd808@tools-sgebastion-11> Restart phorge task to pick up changes for T358653

[23:39]  < wikibugs> Striker, Wikibugs, cloud-services-team (FY2023/2024-Q3-Q4), Patch-For-Review, User-bd808: wikibugs test bug part II - https://phabricator.wikimedia.org/T90594#9594644 (bd808) Is {T358653} fixed?