Object selector cannot select unlabeled object by ZID
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	DVrandecic
	Feb 29 2024, 2:24 AM

Project Tags

Referenced Files

None

Subscribers

Bugreporter

DVrandecic

Jdforrester-WMF

Description

Steps to replicate the issue (include links if applicable):

Create an object without a label e.g. a Function. The following Function has no label: https://wikifunctions.beta.wmflabs.org/view/en/Z11684 (at least it didn't when I created it)
Go to a page that has an object selector for the created object, e.g. for a function go to https://wikifunctions.beta.wmflabs.org/wiki/Special:RunFunction and try to select the new object by ZID - e.g. enter Z11684 into the field on RunFunction

What happens?:
I cannot select that object

What should have happened instead?:
I should be able to select the object

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Insert fake MUL alias to the labels table to make unnamed objects searchable	Genoveva Galarza	mediawiki/extensions/WikiLambda	master	+23 -10

Customize query in gerrit

Related Objects

Mentioned In: T367005: Map function should be correctly type-hinted that it returns a Typed list of Z1s
T373038: fetchZidsOfType only returns objects that have at least one label
T375972: in the object selector, functions that return a Typed list are not available when a Typed list is expected or required
Mentioned Here: T367005: Map function should be correctly type-hinted that it returns a Typed list of Z1s
T375972: in the object selector, functions that return a Typed list are not available when a Typed list is expected or required
T373038: fetchZidsOfType only returns objects that have at least one label

Event Timeline

DVrandecic created this task.Feb 29 2024, 2:24 AM

DVrandecic added a project: WikiLambda Front-end.

In Wikibase the ID is used as a placeholder if there are no labels defined.

Z11684 has no labels in any language, and so no entry in the labels table, so it won't show up in our search. We could special-case the event when the input looks like a ZID and check that manually in addition to the API query?

Maybe repeat the 'mul' hack we have for Z60s to also put the ZID in as a mul alias?

Jdforrester-WMF triaged this task as Low priority.Feb 29 2024, 5:52 PM

Jdforrester-WMF moved this task from To Triage to Backlog on the Abstract Wikipedia team board.

Jdforrester-WMF moved this task from Backlog to 24Q4 (Apr–Jun) on the Abstract Wikipedia team board.Apr 1 2024, 6:50 PM

Jdforrester-WMF edited projects, added: Abstract Wikipedia team (24Q4 (Apr–Jun)); removed: Abstract Wikipedia team.

Jdforrester-WMF moved this task from Incoming to Ready, Bugs on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.Apr 1 2024, 6:59 PM

Jdforrester-WMF moved this task from 24Q4 (Apr–Jun) to 25Q1 (Jul–Sep) on the Abstract Wikipedia team board.Jun 17 2024, 8:24 PM

Jdforrester-WMF edited projects, added: Abstract Wikipedia team (25Q1 (Jul–Sep)); removed: Abstract Wikipedia team (24Q4 (Apr–Jun)).

Jdforrester-WMF moved this task from Incoming to Bugs to investigate on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.Jun 17 2024, 8:31 PM

Jdforrester-WMF moved this task from 25Q1 (Jul–Sep) to 25Q2 (Oct–Dec) on the Abstract Wikipedia team board.Oct 8 2024, 1:58 PM

Jdforrester-WMF edited projects, added: Abstract Wikipedia team (25Q2 (Oct–Dec)); removed: Abstract Wikipedia team (25Q1 (Jul–Sep)).

Jdforrester-WMF moved this task from Incoming to Bugs to investigate on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.Oct 8 2024, 2:09 PM

gengh claimed this task.Nov 8 2024, 9:05 AM

gengh moved this task from Bugs to investigate to In Engineering on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.

Change #1088549 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Insert fake MUL alias to the labels table to make unnamed objects searchable

https://gerrit.wikimedia.org/r/1088549

gerritbot added a project: Patch-For-Review.Nov 8 2024, 12:01 PM

gengh moved this task from In Engineering to In Code review on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.Nov 8 2024, 12:02 PM

Maybe repeat the 'mul' hack we have for Z60s to also put the ZID in as a mul alias?

I followed @Jdforrester-WMF recommendation. For each object, a fake alias for language Multilingual/Z1360 and with the Zid as label is added to the secondary labels table.
This affects search, allowing contributors to find and select objects that aren't labelled.
This also means that the issue described in T373038 is now solved.

We need to run the updateSeocondaryTables maintenance script in production for all types.

Jdforrester-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.Nov 11 2024, 2:23 PM

Change #1088549 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Insert fake MUL alias to the labels table to make unnamed objects searchable

https://gerrit.wikimedia.org/r/1088549

Maintenance_bot removed a project: Patch-For-Review.Nov 11 2024, 4:31 PM

Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.Nov 13 2024, 8:09 PM

Mentioned in SAL (#wikimedia-operations) [2024-11-14T19:20:16Z] <James_F> Running mwscript-k8s -f -- extensions/WikiLambda/maintenance/updateSecondaryTables.php --wiki=wikifunctionswiki --zType Z8 --report --verbose for T375972, T367005, T373038, T358737

Stashbot mentioned this in T375972: in the object selector, functions that return a Typed list are not available when a Typed list is expected or required .Nov 14 2024, 7:20 PM

Stashbot mentioned this in T373038: fetchZidsOfType only returns objects that have at least one label.

Stashbot mentioned this in T367005: Map function should be correctly type-hinted that it returns a Typed list of Z1s.

Jdforrester-WMF closed this task as Resolved.Nov 25 2024, 4:09 PM

Object selector cannot select unlabeled object by ZIDClosed, ResolvedPublicBUG REPORTActions

Description

Details

Related Objects

Event Timeline

Object selector cannot select unlabeled object by ZID
Closed, ResolvedPublicBUG REPORT
Actions