Page MenuHomePhabricator

Mobile rejections (wpReject) doesn't work
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Go to pl.m.wikipedia to an unreviewed page.
  • Click on "Anuluj zmiany" (wpReject).
  • (optional) change message rejecting changes.
  • Confirm rejection.

What happens?:
Shows desktop page with some session related message and changes are not rejected.

What should have happened instead?:
Show mobile page, changes should be rejected (withdrawn; reverted with a message).

Software version (skip for WMF-hosted wikis like Wikipedia):

I think it worked last week or a week before that (not sure when did I last use mobile rejections). So maybe related to mobile diff changes? T353479

Other information (browser name/version, screenshots, etc.):

starting the processsession messagemy browser
image.png (1×576 px, 361 KB)
image.png (1×576 px, 157 KB)
image.png (1×794 px, 379 KB)

Event Timeline

Change #1017481 had a related patch set uploaded (by Wargo; author: Wargo):

[mediawiki/extensions/FlaggedRevs@master] FlaggedRevs: use getLocalURL in reject form action parameter

https://gerrit.wikimedia.org/r/1017481

Confirmed to work on patchdemo :-)
https://patchdemo.wmflabs.org/wikis/745f82bb2b/w/index.php?title=1886_in_Chile&oldid=154&diff=cur

The url is indeed relative ✅ and the form still works ✅.

image.png (430×1 px, 83 KB)

Change #1017481 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] FlaggedRevs: use getLocalURL in reject form action parameter

https://gerrit.wikimedia.org/r/1017481

Confirmed to work on patchdemo :-)

Patchdemo hasn't .m subdomain but now tested on Beta.