Page MenuHomePhabricator

Deleting the last inline comments should restore the page to default display
Open, Needs TriagePublic

Description

In the InlineComments extension, if you delete/"mark resolved" all the comments on a page, the empty space on the side remains there - you have to reload the page for it to go away. It would be better if the empty space went away immediately on deletion.

Event Timeline

Change #1014143 had a related patch set uploaded (by Rockingpenny4; author: Rockingpenny4):

[mediawiki/extensions/InlineComments@master] Fixes extra spacing on resolving comments

https://gerrit.wikimedia.org/r/1014143

@Yaron_Koren on inspecting the CSS , element.style adds an extra top of 10px which is dissolved on reloading , so I have made a fix for that which does it immediately however it also subtracts the 10px from the initial comments without resolving.
Before :

After:

@Rockingpenny4 - this seems like a useful change, but is it related to the original bug/task?

@Yaron_Koren , my apologies I seem to have misunderstood the original bug , should I make a separate task for this new bug and point my patch to it or club the fix for original bug with existing patch? Meanwhile I will work on a fix for this bug.

You could create a separate task for this patch, or just have no task for the patch - not every patch needs an associated task.

Change #1014524 had a related patch set uploaded (by Rockingpenny4; author: Rockingpenny4):

[mediawiki/extensions/InlineComments@master] Restores the page to default page on resolving all comments

https://gerrit.wikimedia.org/r/1014524

I have made a fix for this bug. Here is the relevant screencast:

As an aside, i had no idea this overlapped the toolbox on new vector. Guess i should be testing on that skin every now and then

Change #1014143 abandoned by Rockingpenny4:

[mediawiki/extensions/InlineComments@master] Fixes extra spacing on resolving comments

Reason:

Unnecessary

https://gerrit.wikimedia.org/r/1014143