Maniphest T358949

PHP Deprecated: Implicit conversion from float to int loses precision in maintenance/updateCollation.php on line 458
Closed, ResolvedPublic
Actions

Description

Happens when --verbose-stats is used.

Noticed on MW 1.40.2 but it doesn't seem the code has been updated after that.

Details

	Subject	Repo	Branch	Lines +/-
	updateCollation: Explicitly cast $scale to int	mediawiki/core	REL1_41	+1 -1
	updateCollation: Explicitly cast $scale to int	mediawiki/core	REL1_40	+1 -1
	updateCollation: Explicitly cast $scale to int	mediawiki/core	REL1_39	+1 -1
	updateCollation: Explicitly cast $scale to int	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: rMW8df24d558639: updateCollation.php size histogram feature

Event Timeline

Nikerabbit created this task.Mar 2 2024, 11:24 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 2 2024, 11:24 AM

		for ( $coarseIndex = 0; $coarseIndex < $numBins; $coarseIndex++ ) {
			$val = $coarseHistogram[$coarseIndex] ?? 0;
			// @phan-suppress-next-line PhanTypePossiblyInvalidDimOffset False positive
			$boundary = $coarseBoundaries[$coarseIndex];
			$this->output( sprintf( "%-10s %-10d |%s\n",
				$prevBoundary . '-' . ( $boundary - 1 ) . ': ',
				$val,
				str_repeat( '*', $scale * $val ) ) );
			$prevBoundary = $boundary;
		}

458 in 1.40 is str_repeat( '*', $scale * $val ) ) );

Which is line 395 in master.

Heh, the code is basically unchanged for over a decade since it was added rMW8df24d558639: updateCollation.php size histogram feature

Change 1008056 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] updateCollation: Explicitly cast $scale to int

https://gerrit.wikimedia.org/r/1008056

gerritbot added a project: Patch-For-Review.Mar 2 2024, 10:09 PM

Change 1008056 merged by jenkins-bot:

[mediawiki/core@master] updateCollation: Explicitly cast $scale to int

https://gerrit.wikimedia.org/r/1008056

Change 1008010 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_41] updateCollation: Explicitly cast $scale to int

https://gerrit.wikimedia.org/r/1008010

Change 1008011 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_40] updateCollation: Explicitly cast $scale to int

https://gerrit.wikimedia.org/r/1008011

Change 1008012 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_39] updateCollation: Explicitly cast $scale to int

https://gerrit.wikimedia.org/r/1008012

Reedy closed this task as Resolved.Mar 2 2024, 11:55 PM

Reedy claimed this task.

Change 1008010 merged by jenkins-bot:

[mediawiki/core@REL1_41] updateCollation: Explicitly cast $scale to int

https://gerrit.wikimedia.org/r/1008010

Change 1008012 merged by jenkins-bot:

[mediawiki/core@REL1_39] updateCollation: Explicitly cast $scale to int

https://gerrit.wikimedia.org/r/1008012

Change 1008011 merged by jenkins-bot:

[mediawiki/core@REL1_40] updateCollation: Explicitly cast $scale to int

https://gerrit.wikimedia.org/r/1008011

Maintenance_bot removed a project: Patch-For-Review.Mar 3 2024, 12:30 AM

ReleaseTaggerBot added projects: MW-1.39-notes, MW-1.42-notes (1.42.0-wmf.21; 2024-03-05), MW-1.40-notes, MW-1.41-notes.Mar 3 2024, 1:00 AM