Page MenuHomePhabricator

[wmcs-backup] exclude_volumes is matching on IDs instead of names
Closed, ResolvedPublicBUG REPORT

Description

wmcs-backups has a config file where you can specify a list of regexes to exclude some volumes from being backed up:

exclude_volumes:
  cloudinfra-nfs:
    - scratch
  admin-monitoring:
    - ".*"
[...]

This is not working correctly because the code in wmcs-backup.py is matching the regex against the image ID (e.g. d1478efd-9fa6-4293-8389-e72459b794c0) instead of the image name (e.g. scratch)

Event Timeline

fnegri changed the task status from Open to In Progress.Mar 5 2024, 4:23 PM
fnegri claimed this task.
fnegri triaged this task as Medium priority.
fnegri created this task.

Change 1009787 had a related patch set uploaded (by FNegri; author: FNegri):

[operations/puppet@production] [wmcs-backup] WIP: Add dummy test

https://gerrit.wikimedia.org/r/1009787

Change #1009787 merged by FNegri:

[operations/puppet@production] [wmcs-backup] Fix parsing of exclude_volumes

https://gerrit.wikimedia.org/r/1009787

Change #1016806 had a related patch set uploaded (by Andrew Bogott; author: Andrew Bogott):

[operations/puppet@production] wmcs-backup.py: replace image_id with image_info in a few more places

https://gerrit.wikimedia.org/r/1016806

Change #1016806 merged by Andrew Bogott:

[operations/puppet@production] wmcs-backup.py: replace image_id with image_info in a few more places

https://gerrit.wikimedia.org/r/1016806