In MW 1.19 it fails under some circumstances due to a not-declarded dependency to mw.user.anonymous(). Patch follows.
Version: unspecified
Severity: major
Rillke | |
Jan 24 2012, 6:51 PM |
F8623: SpecialBannerControllerpatch.php | |
Nov 22 2014, 12:05 AM |
In MW 1.19 it fails under some circumstances due to a not-declarded dependency to mw.user.anonymous(). Patch follows.
Version: unspecified
Severity: major
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | None | T33217 MediaWiki bugs to be fixed for 1.19wmf1 deployment (tracking) | |||
Resolved | kaldari | T35931 Missing dependency to mw.user |
Created attachment 9902
Add a dependency to /mediawiki/trunk/extensions/CentralNotice/special/SpecialBannerController.php
Add a dependency to /mediawiki/trunk/extensions/CentralNotice/special/SpecialBannerController.php
I think that's the most fast solution: Until the callback, other gadgets might have loaded the mw.user module and further deferring the XHR by waiting for mw.user might not be the best.
Evaluate yourself.
Attached: