Page MenuHomePhabricator

Missing dependency to mw.user
Closed, ResolvedPublic

Description

In MW 1.19 it fails under some circumstances due to a not-declarded dependency to mw.user.anonymous(). Patch follows.


Version: unspecified
Severity: major

Details

Reference
bz33931

Event Timeline

Created attachment 9902
Add a dependency to /mediawiki/trunk/extensions/CentralNotice/special/SpecialBannerController.php

Add a dependency to /mediawiki/trunk/extensions/CentralNotice/special/SpecialBannerController.php

I think that's the most fast solution: Until the callback, other gadgets might have loaded the mw.user module and further deferring the XHR by waiting for mw.user might not be the best.

Evaluate yourself.

Attached:

Fixed in r109977. Thanks for the patch!