Page MenuHomePhabricator
Create Task
Maniphest T359347

(mw.track) Migrate MediaWiki.echo.* to statslib
Closed, ResolvedPublic
Actions

Description

Background

Graphite is scheduled to become read-only by March 2023 (Q3-FY2024/2025). The sooner metrics are migrated, the more history and continuity a dashboard will have after the transition. Old data can still be queried from Graphite directly. Consider using "Save as" to create a copy of your Grafana dashboard and rename it to "My Name (old Graphite)" to ease viewing of old data in the future, even after you've updated your dashboard to use Prometheus.

JS change

Update the relevant dashboard(s) by replacing the old Graphite metric(s) with the new Prometheus metric(s).

TODO:

  • MediaWiki.echo.event.mention.notification.*
  • MediaWiki.echo.event.mention.error
  • MediaWiki.echo.event.*
  • MediaWiki.echo.notification
  • MediaWiki.echo.overlay.*
  • MediaWiki.echo.unseen.click

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
statslib(init.js): migrate timing metricsSergio Gimenomediawiki/extensions/Echomaster+18 -3
statslib: migrate countersSergio Gimenomediawiki/extensions/Echomaster+14 -8
statslib(DiscussionParser): remove no longer consumed metricsSergio Gimenomediawiki/extensions/Echomaster+0 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

• lmata created this task.Mar 6 2024, 1:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2024, 1:27 PM
• lmata mentioned this in T350592: EPIC: migrate in use metrics and dashboards to statslib.Mar 6 2024, 1:31 PM
colewhite renamed this task from Migrate MediaWiki.echo.* to statslib to (mw.track) Migrate MediaWiki.echo.* to statslib.Apr 26 2024, 4:39 PM
colewhite updated the task description. (Show Details)
MSantos added subscribers: Mooeypoo, Catrope, MSantos.Aug 14 2024, 2:57 PM

@Catrope and @Mooeypoo which team backlog should this be on?

kostajh added projects: Notifications (Echo), Growth-Team.Aug 20 2024, 3:56 PM
kostajh subscribed.

If we don't use these metrics, we could also switch some of them off rather than convert them.

Michael moved this task from Inbox to Triaged on the Growth-Team board.Sep 3 2024, 11:14 AM
Michael added subscribers: lilients_WMDE, herron, WMDE-Fisch, Michael.
In T359347#10078225, @kostajh wrote:

If we don't use these metrics, we could also switch some of them off rather than convert them.

When looking at actual Grafana dashboards for the Echo extension, I'm noticing that two are maintained by WMDE-TechWish:

@WMDE-Fisch and @lilients_WMDE: any thoughts on the value of those dashboards?

https://grafana-rw.wikimedia.org/d/onyD7cOMk/echo-extension-notification-baseline-track on the other hand was created by "anonymous" (why do allow user without account to edit Grafana?), but seems to actually use some of the metrics above. It also lives in the user-space on Grafana and does not seem associated with a team. Later it was edited by @herron, but I'm not sure if that was a substantial edit indicating any ownership or need.

https://grafana.wikimedia.org/d/000000016/echo-job-pickup is actually in the Growth-Team folder, but, as far as I can tell, not actively reviewed by us. Also, it does not seem to use above metrics?

I think https://grafana.wikimedia.org/d/IfJykaTZk/echostore is not actually about the Echo extension, but honestly: I can't tell.

WMDE-Fisch added a comment.Sep 3 2024, 1:47 PM
In T359347#10112481, @Michael wrote:

@WMDE-Fisch and @lilients_WMDE: any thoughts on the value of those dashboards?

I'll quickly check back with our PM but I think we can just remove them. ( would just be nice to do that in a way that no loose ends pollute the code anywhere )

https://grafana-rw.wikimedia.org/d/onyD7cOMk/echo-extension-notification-baseline-track on the other hand was created by "anonymous" (why do allow user without account to edit Grafana?)

When you search Phab for that link you'll find https://phabricator.wikimedia.org/T260836#6463578 :-D

matej_suchanek subscribed.Sep 23 2024, 6:35 PM

I've just discovered a bug in one of the dashboards: T375415: Echo notification stats are broken.

Sgs subscribed.Sep 25 2024, 1:09 PM
kostajh added a comment.Oct 2 2024, 12:54 PM
In T359347#10113046, @WMDE-Fisch wrote:
In T359347#10112481, @Michael wrote:

@WMDE-Fisch and @lilients_WMDE: any thoughts on the value of those dashboards?

I'll quickly check back with our PM but I think we can just remove them. ( would just be nice to do that in a way that no loose ends pollute the code anywhere )

@WMDE-Fisch hi, any update on this?

WMDE-Fisch added a comment.EditedOct 8 2024, 12:44 PM
In T359347#10195734, @kostajh wrote:
In T359347#10113046, @WMDE-Fisch wrote:
In T359347#10112481, @Michael wrote:

@WMDE-Fisch and @lilients_WMDE: any thoughts on the value of those dashboards?

I'll quickly check back with our PM but I think we can just remove them. ( would just be nice to do that in a way that no loose ends pollute the code anywhere )

@WMDE-Fisch hi, any update on this?

Yes. sorry that I did not get back to you yet. So it there's no interest from our side to keep these things. Our PM did trigger a poke towards @Mooeypoo in Slack if there's some need from that direction where I'm not sure if there's an answer to that yet. But that also was two weeks ago.

Tl;dr: For the WMDE-TechWish team it's fine to get rid of that.

colewhite subscribed.EditedOct 17 2024, 8:14 PM
In T359347#10210408, @WMDE-Fisch wrote:
In T359347#10112481, @Michael wrote:

Tl;dr: For the WMDE-TechWish team it's fine to get rid of that.

Marked the dashboards for cleanup. Thank you!

Krinkle updated the task description. (Show Details)Dec 19 2024, 11:04 PM
Krinkle mentioned this in T355837: Add Prometheus support to statsd.js via mw.track().Dec 20 2024, 12:37 AM
Sgs triaged this task as Medium priority.Jan 16 2025, 5:04 PM
Sgs moved this task from Triaged to Maintenance on the Growth-Team board.
Sgs edited projects, added: Growth-Team (Maintenance); removed: Growth-Team.
Sgs moved this task from Backlog to Statslib migration on the Growth-Team (Maintenance) board.
colewhite mentioned this in T383953: Statsv support for timer metrics.Jan 17 2025, 12:22 AM
gerritbot added a comment.Jan 17 2025, 3:23 PM

Change #1112237 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/Echo@master] statslib(DiscussionParser): remove no longer consumed metrics

https://gerrit.wikimedia.org/r/1112237

gerritbot added a project: Patch-For-Review.Jan 17 2025, 3:23 PM

Change #1112238 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/Echo@master] statslib: migrate counters

https://gerrit.wikimedia.org/r/1112238

gerritbot added a comment.Jan 17 2025, 3:24 PM

Change #1112239 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/Echo@master] statslib(init.js): migrate metrics

https://gerrit.wikimedia.org/r/1112239

Sgs claimed this task.Jan 17 2025, 3:34 PM
Sgs edited projects, added: Growth-Team (Current Sprint); removed: Growth-Team (Maintenance).
Sgs moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.
gerritbot added a comment.Jan 20 2025, 2:46 PM

Change #1112237 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] statslib(DiscussionParser): remove no longer consumed metrics

https://gerrit.wikimedia.org/r/1112237

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.13; 2025-01-21).Jan 20 2025, 3:00 PM
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.Jan 20 2025, 8:57 PM
Urbanecm_WMF moved this task from QA to Doing on the Growth-Team (Current Sprint) board.
Sgs added a comment.Jan 22 2025, 1:55 PM

Migrating timing metrics is blocked on T383953/T384289 resolution.

Sgs moved this task from Doing to Blocked / Needs Work on the Growth-Team (Current Sprint) board.Jan 22 2025, 1:55 PM
gerritbot added a comment.Feb 3 2025, 9:35 AM

Change #1112238 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] statslib: migrate counters

https://gerrit.wikimedia.org/r/1112238

ReleaseTaggerBot edited projects, added: MW-1.44-notes (1.44.0-wmf.15; 2025-02-04); removed: MW-1.44-notes (1.44.0-wmf.13; 2025-01-21).Feb 3 2025, 10:00 AM
Sgs moved this task from Blocked / Needs Work to Doing on the Growth-Team (Current Sprint) board.Feb 11 2025, 9:22 AM
Sgs moved this task from Doing to Code Review on the Growth-Team (Current Sprint) board.Feb 12 2025, 4:16 PM
gerritbot added a comment.Feb 14 2025, 10:34 AM

Change #1112239 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] statslib(init.js): migrate timing metrics

https://gerrit.wikimedia.org/r/1112239

ReleaseTaggerBot edited projects, added: MW-1.44-notes (1.44.0-wmf.17; 2025-02-18); removed: MW-1.44-notes (1.44.0-wmf.15; 2025-02-04).Feb 14 2025, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 14 2025, 11:30 AM
Sgs added a comment.Feb 14 2025, 11:50 AM

Moving back to incoming since this probably requires Grafana dashboard updates, although I'm not working on it until next week.

Sgs moved this task from Code Review to Incoming on the Growth-Team (Current Sprint) board.Feb 14 2025, 11:50 AM
colewhite closed this task as Resolved.Mar 14 2025, 3:57 PM

Dashboards migrated

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits