Page MenuHomePhabricator

Migrate MediaWiki.Parsoid.html2wt to statslib
Closed, ResolvedPublic

Description

Follow the migration process as outlined below.

Secure/Conduct code review(s).
Deploy the changes to production via the train (https://wikitech.wikimedia.org/wiki/Deployments/Train).
Verify that the changes have been successfully implemented.
Update the relevant dashboard(s) by replacing the old Graphite metric(s) with the new Prometheus metric(s).
Please follow the guidelines and standards outlined in the provided documentation:

https://www.mediawiki.org/wiki/Manual:Stats for detailed guidance on the conversion process.
https://drive.google.com/file/d/12yQEuOapkML1vb9MgCaX1QzbLBdXE6X2/view for a video tutorial on the conversion process.
https://docs.google.com/presentation/d/1SZWf_D3mWNX-XHN8PHYI84LDZr6GUQC2AMhZ9mQXCI0/edit#slide=id.g2795460c956_0_23 for slides on the best practices for converting metrics to statslib.

  • MediaWiki.Parsoid.html2wt.init.mean
  • MediaWiki.Parsoid.html2wt.init.median
  • MediaWiki.Parsoid.html2wt.init.p50
  • MediaWiki.Parsoid.html2wt.init.p75
  • MediaWiki.Parsoid.html2wt.init.p95
  • MediaWiki.Parsoid.html2wt.init.p99
  • MediaWiki.Parsoid.html2wt.init.upper
  • MediaWiki.Parsoid.html2wt.preprocess.p75
  • MediaWiki.Parsoid.html2wt.selser.domDiff.mean
  • MediaWiki.Parsoid.html2wt.selser.domDiff.median
  • MediaWiki.Parsoid.html2wt.selser.domDiff.p50
  • MediaWiki.Parsoid.html2wt.selser.domDiff.p75
  • MediaWiki.Parsoid.html2wt.selser.domDiff.p95
  • MediaWiki.Parsoid.html2wt.selser.domDiff.p99
  • MediaWiki.Parsoid.html2wt.selser.domDiff.upper
  • MediaWiki.Parsoid.html2wt.selser.serialize.mean
  • MediaWiki.Parsoid.html2wt.selser.serialize.median
  • MediaWiki.Parsoid.html2wt.selser.serialize.p50
  • MediaWiki.Parsoid.html2wt.selser.serialize.p75
  • MediaWiki.Parsoid.html2wt.selser.serialize.p95
  • MediaWiki.Parsoid.html2wt.selser.serialize.p99
  • MediaWiki.Parsoid.html2wt.selser.serialize.upper
  • MediaWiki.Parsoid.html2wt.setup.mean
  • MediaWiki.Parsoid.html2wt.setup.p50
  • MediaWiki.Parsoid.html2wt.setup.p75
  • MediaWiki.Parsoid.html2wt.setup.p95
  • MediaWiki.Parsoid.html2wt.setup.p99
  • MediaWiki.Parsoid.html2wt.setup.upper
  • MediaWiki.Parsoid.html2wt.size.input.mean
  • MediaWiki.Parsoid.html2wt.size.input.p50
  • MediaWiki.Parsoid.html2wt.size.input.p75
  • MediaWiki.Parsoid.html2wt.size.input.p95
  • MediaWiki.Parsoid.html2wt.size.input.p99
  • MediaWiki.Parsoid.html2wt.size.input.upper
  • MediaWiki.Parsoid.html2wt.timePerInputKB.mean
  • MediaWiki.Parsoid.html2wt.timePerInputKB.p50
  • MediaWiki.Parsoid.html2wt.timePerInputKB.p75
  • MediaWiki.Parsoid.html2wt.timePerInputKB.p95
  • MediaWiki.Parsoid.html2wt.timePerInputKB.p99
  • MediaWiki.Parsoid.html2wt.timePerInputKB.upper
  • MediaWiki.Parsoid.html2wt.total.mean
  • MediaWiki.Parsoid.html2wt.total.median
  • MediaWiki.Parsoid.html2wt.total.p50
  • MediaWiki.Parsoid.html2wt.total.p75
  • MediaWiki.Parsoid.html2wt.total.p95
  • MediaWiki.Parsoid.html2wt.total.p99
  • MediaWiki.Parsoid.html2wt.total.sample_rate
  • MediaWiki.Parsoid.html2wt.total.upper

Event Timeline

tappof added subscribers: Jgiannelos, tappof.

{F58025657}

All of these no longer seem to be populated, so I'm removing the panels from the dashboard. The preprocess metric translates to html2wt_preprocess_seconds, but it is not used in any dashboard.

updated dashboards:

MediaWiki.Parsoid.html2wt.init --> deprecated
MediaWiki.Parsoid.html2wt.preprocess --> html2wt_preprocess_seconds
MediaWiki.Parsoid.html2wt.selser.domDiff --> html2wt_domDiff_seconds
MediaWiki.Parsoid.html2wt.selser.serialize --> html2wt_serialize_seconds
MediaWiki.Parsoid.html2wt.setup --> html2wt_setup_seconds
MediaWiki.Parsoid.html2wt.size.input --> html2wt_size_input_bytes
MediaWiki.Parsoid.html2wt.timePerInputKB --> html2wt_msPerKB
MediaWiki.Parsoid.html2wt.total --> deprecated

tappof changed the task status from Open to Stalled.Dec 18 2024, 1:21 PM
tappof updated the task description. (Show Details)

Hi @Jgiannelos, I noticed you marked the task as complete, but also restored the legacy dashboard a few days ago. Just to confirm—if the task is indeed complete, can we go ahead and delete the legacy dashboard?
Link: https://grafana.wikimedia.org/goto/ESyrAK0HR?orgId=1
CC: @tappof

Yes, I restored just to see the metrics of the old dashboard.