Page MenuHomePhabricator

Migrate charts to Calico Network Policies
Open, MediumPublic

Description

The following charts will need to be migrated to the base.networkpolicy.egress.external-services helm template, rendering Calico network policies:

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
JMeybohmoperations/deployment-chartsmaster+33 -2
JMeybohmoperations/puppetproduction+17 -4
Scott Frenchoperations/deployment-chartsmaster+74 -32
Brouberoloperations/deployment-chartsmaster+30 -43
Brouberoloperations/deployment-chartsmaster+10 -3
Brouberoloperations/deployment-chartsmaster+8 -8
Brouberoloperations/deployment-chartsmaster+1 -1
Brouberoloperations/deployment-chartsmaster+257 -8
Brouberoloperations/deployment-chartsmaster+19 -38
Btullisoperations/deployment-chartsmaster+181 -323
Scott Frenchoperations/deployment-chartsmaster+82 -26
JMeybohmoperations/deployment-chartsmaster+80 -47
JMeybohmoperations/deployment-chartsmaster+123 -73
Klausmanoperations/deployment-chartsmaster+119 -3
JMeybohmoperations/deployment-chartsmaster+5 -185
JMeybohmoperations/deployment-chartsmaster+5 -184
JMeybohmoperations/deployment-chartsmaster+63 -5
JMeybohmoperations/deployment-chartsmaster+123 -73
Btullisoperations/deployment-chartsmaster+3 -3
Btullisoperations/deployment-chartsmaster+1 -1
Brouberoloperations/deployment-chartsmaster+7 -1
Brouberoloperations/deployment-chartsmaster+12 -4
Brouberoloperations/deployment-chartsmaster+7 -70
Brouberoloperations/deployment-chartsmaster+49 -3
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change #1014540 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] changeprop: Migrate to base.external-services-networkpolicy

https://gerrit.wikimedia.org/r/1014540

Change #1014542 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] changeprop-jobqueue: Migrate to base.external-services-networkpolicy

https://gerrit.wikimedia.org/r/1014542

Change #1014646 had a related patch set uploaded (by Btullis; author: Btullis):

[operations/deployment-charts@master] Fix typo in the external-services values for datahub staging

https://gerrit.wikimedia.org/r/1014646

I needed to start work on the DataHub migration because SSO broke due to the switch of IDP servers: https://sal.toolforge.org/log/UMCPdY4BhuQtenzvi5Pe

Slack thread here.

CR here: https://gerrit.wikimedia.org/r/c/operations/deployment-charts/+/1014065

So far, I have only migrated the CAS IDP services, but there are still several others that can be migrated too, including:

  • datahubsearch
  • mariadb (analytics_meta)

We can probably remove the LDAP policies from this deployment, now that CAS is enabled. Otherwise I would migrate that too.

Change #1014646 merged by jenkins-bot:

[operations/deployment-charts@master] Fix whitespace in the external-services values for datahub staging

https://gerrit.wikimedia.org/r/1014646

Change #1014652 had a related patch set uploaded (by Btullis; author: Btullis):

[operations/deployment-charts@master] Make datahub networkpolicy include/template consistent

https://gerrit.wikimedia.org/r/1014652

Change #1015029 had a related patch set uploaded (by Klausman; author: Klausman):

[operations/deployment-charts@master] charts/kserve-inference: Wire up generated network policy for LW services

https://gerrit.wikimedia.org/r/1015029

Change #1014652 merged by jenkins-bot:

[operations/deployment-charts@master] Make datahub networkpolicy include/template consistent

https://gerrit.wikimedia.org/r/1014652

Change #1014538 merged by jenkins-bot:

[operations/deployment-charts@master] changeprop: Update mesh modules

https://gerrit.wikimedia.org/r/1014538

Change #1014539 merged by jenkins-bot:

[operations/deployment-charts@master] changeprop: Add base.external-services-networkpolicy:1.0

https://gerrit.wikimedia.org/r/1014539

Change #1014540 merged by jenkins-bot:

[operations/deployment-charts@master] changeprop: Migrate to base.external-services-networkpolicy

https://gerrit.wikimedia.org/r/1014540

Change #1014542 merged by jenkins-bot:

[operations/deployment-charts@master] changeprop-jobqueue: Migrate to base.external-services-networkpolicy

https://gerrit.wikimedia.org/r/1014542

Change #1015029 merged by jenkins-bot:

[operations/deployment-charts@master] charts/kserve-inference: Wire up generated network policy for LW services

https://gerrit.wikimedia.org/r/1015029

Grouped the todo list by chart, some of those also need mesh.configuration updates due to T346638: Rename the envoy's uses_ingress option to sets_sni which could be bundled with this

Change #1019007 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] eventgate: Update mesh modules

https://gerrit.wikimedia.org/r/1019007

Change #1019018 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] eventgate-*: Migrate to base.external-services-networkpolicy

https://gerrit.wikimedia.org/r/1019018

Change #1019007 merged by jenkins-bot:

[operations/deployment-charts@master] eventgate: Update mesh modules

https://gerrit.wikimedia.org/r/1019007

Change #1019018 merged by jenkins-bot:

[operations/deployment-charts@master] eventgate-*: Migrate to base.external-services-networkpolicy

https://gerrit.wikimedia.org/r/1019018

BTullis updated the task description. (Show Details)

Change #1028910 had a related patch set uploaded (by Scott French; author: Scott French):

[operations/deployment-charts@master] benthos: adopt securityContext and base.external-services-networkpolicy

https://gerrit.wikimedia.org/r/1028910

Change #1028910 merged by jenkins-bot:

[operations/deployment-charts@master] benthos: adopt securityContext and base.external-services-networkpolicy

https://gerrit.wikimedia.org/r/1028910

Change #1033405 had a related patch set uploaded (by Btullis; author: Btullis):

[operations/deployment-charts@master] Migrate AQS2 services and image-suggestions to calico network policies

https://gerrit.wikimedia.org/r/1033405

Change #1033405 merged by jenkins-bot:

[operations/deployment-charts@master] Migrate AQS2 services and image-suggestions to calico network policies

https://gerrit.wikimedia.org/r/1033405

Change #1037870 had a related patch set uploaded (by Scott French; author: Scott French):

[operations/deployment-charts@master] eventstreams: adopt base.external-services-networkpolicy

https://gerrit.wikimedia.org/r/1037870

Change #1040874 had a related patch set uploaded (by Brouberol; author: Brouberol):

[operations/deployment-charts@master] datahub-next: replace IPs by Services in network policies

https://gerrit.wikimedia.org/r/1040874

Change #1040875 had a related patch set uploaded (by Brouberol; author: Brouberol):

[operations/deployment-charts@master] datahub: replace IPs by Services in network policies

https://gerrit.wikimedia.org/r/1040875

Change #1040874 merged by Brouberol:

[operations/deployment-charts@master] datahub-next: replace IPs by Services in network policies

https://gerrit.wikimedia.org/r/1040874

Change #1041671 had a related patch set uploaded (by Brouberol; author: Brouberol):

[operations/deployment-charts@master] datahub: update datahubsearch hostname to use external-services

https://gerrit.wikimedia.org/r/1041671

Change #1041676 had a related patch set uploaded (by Brouberol; author: Brouberol):

[operations/deployment-charts@master] Deploy calico network policy templates to all datahub charts

https://gerrit.wikimedia.org/r/1041676

Change #1041676 merged by Brouberol:

[operations/deployment-charts@master] Deploy calico network policy templates to all datahub charts

https://gerrit.wikimedia.org/r/1041676

Change #1042952 had a related patch set uploaded (by Brouberol; author: Brouberol):

[operations/deployment-charts@master] datahub-next: restore IP-based networkpolicy to datahubsearch

https://gerrit.wikimedia.org/r/1042952

Change #1041671 abandoned by Brouberol:

[operations/deployment-charts@master] datahub: update datahubsearch hostname to use external-services

Reason:

https://gerrit.wikimedia.org/r/1041671

Change #1042964 had a related patch set uploaded (by Brouberol; author: Brouberol):

[operations/deployment-charts@master] datahub: fix label matching beetween pods and networkpolicies

https://gerrit.wikimedia.org/r/1042964

Change #1042964 merged by jenkins-bot:

[operations/deployment-charts@master] datahub: fix label matching beetween pods and networkpolicies

https://gerrit.wikimedia.org/r/1042964

Change #1042952 merged by jenkins-bot:

[operations/deployment-charts@master] datahub-next: restore IP-based networkpolicy to datahubsearch

https://gerrit.wikimedia.org/r/1042952

Change #1040875 merged by Brouberol:

[operations/deployment-charts@master] datahub: replace IPs by Services in network policies

https://gerrit.wikimedia.org/r/1040875

Change #1037870 merged by jenkins-bot:

[operations/deployment-charts@master] eventstreams: adopt base.external-services-networkpolicy

https://gerrit.wikimedia.org/r/1037870

Change #1068754 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/puppet@production] global_config: Add pki::multirootca IPs to external-services

https://gerrit.wikimedia.org/r/1068754

Change #1068768 had a related patch set uploaded (by JMeybohm; author: JMeybohm):

[operations/deployment-charts@master] cfssl-issuer: Add external-services support

https://gerrit.wikimedia.org/r/1068768

Change #1068754 merged by JMeybohm:

[operations/puppet@production] global_config: Add pki::multirootca IPs to external-services

https://gerrit.wikimedia.org/r/1068754

Change #1068768 merged by jenkins-bot:

[operations/deployment-charts@master] cfssl-issuer: Add external-services support

https://gerrit.wikimedia.org/r/1068768

Checking in, it looks like we still have a couple of services on Wikikube that require migration, most notably MediaWiki (or, IIUC, cleanup of the older duplicate network policies, as in the tegola-vector-tiles case).

@JMeybohm - Do you happen to recall whether there was an earlier effort to adopt external-services in MediaWiki, and / or what, if anything might have blocked that?

@JMeybohm - Do you happen to recall whether there was an earlier effort to adopt external-services in MediaWiki, and / or what, if anything might have blocked that?

AFAIK no efforts have been made so far, probably a :scooby afraid: situation.

@JMeybohm - Do you happen to recall whether there was an earlier effort to adopt external-services in MediaWiki, and / or what, if anything might have blocked that?

AFAIK no efforts have been made so far, probably a :scooby afraid: situation.

For risk management/clarity as it may require more exploratory work than other charts, I think work to migrate mediawiki to external-services should be tracked in its own task.