Page MenuHomePhabricator
Create Task
Maniphest T359437

Ensure Damaged UI shows "Not Found" when a message no longer exist
Closed, ResolvedPublic
Actions

Description

Currently the Damaged UI displays this error when an attempt is made to fetch a message that no longer exist in the database:

TypeError: Return value of CRM_Damaged_BAO_Damaged::retrieve() must be an instance of CRM_Damaged_BAO_Damaged, null returned in CRM_Damaged_BAO_Damaged::retrieve() (line 41 of /srv/org.wikimedia.civicrm/drupal/sites/default/civicrm/extensions/damaged/CRM/Damaged/BAO/Damaged.php).

We need to show a "Message not found" error instead.

Details

SubjectRepoBranchLines +/-
Fix Damaged row details errorwikimedia/fundraising/crmmaster+42 -24
Customize query in gerrit

Event Timeline

Damilare created this task.Mar 6 2024, 7:16 PM
Restricted Application added a project: Fundraising-Backlog. · View Herald TranscriptMar 6 2024, 7:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
greg triaged this task as Medium priority.Mar 11 2024, 3:27 PM
XenoRyet moved this task from Triage to DRI Backlog on the Fundraising-Backlog board.Mar 11 2024, 6:46 PM
Damilare claimed this task.Mar 14 2024, 8:06 PM
Damilare moved this task from Backlog to In Progress on the Fundraising Tech - Chaos Crew board.
gerritbot added a comment.Mar 15 2024, 4:35 PM

Change 1011312 had a related patch set uploaded (by Damilare Adedoyin; author: Damilare Adedoyin):

[wikimedia/fundraising/crm@master] Fix Damaged row details error

https://gerrit.wikimedia.org/r/1011312

gerritbot added a project: Patch-For-Review.Mar 15 2024, 4:35 PM
Damilare moved this task from In Progress to Ready for Review on the Fundraising Tech - Chaos Crew board.Mar 15 2024, 4:36 PM
gerritbot added a comment.Mar 17 2024, 9:01 PM

Change 1011312 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Fix Damaged row details error

https://gerrit.wikimedia.org/r/1011312

Maintenance_bot removed a project: Patch-For-Review.Mar 17 2024, 9:30 PM
Damilare moved this task from Ready for Review to Pending Deployment on the Fundraising Tech - Chaos Crew board.Mar 18 2024, 1:00 PM
Damilare moved this task from Pending Deployment to Blocked on the Fundraising Tech - Chaos Crew board.Mar 21 2024, 1:52 PM
Damilare moved this task from Blocked to Done on the Fundraising Tech - Chaos Crew board.
XenoRyet closed this task as Resolved.Mar 25 2024, 7:21 PM
XenoRyet set Final Story Points to 4.
Dwisehaupt moved this task from Done to Completed 20240312 - 20240326 on the Fundraising Tech - Chaos Crew board.Mar 26 2024, 7:46 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL