Page MenuHomePhabricator
Create Task
Maniphest T359480

Migrate MediaWiki.global_blocking to statslib
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Follow the migration process as outlined below.

Secure/Conduct code review(s).
Deploy the changes to production via the train (https://wikitech.wikimedia.org/wiki/Deployments/Train).
Verify that the changes have been successfully implemented.
Update the relevant dashboard(s) by replacing the old Graphite metric(s) with the new Prometheus metric(s).
Please follow the guidelines and standards outlined in the provided documentation:

https://www.mediawiki.org/wiki/Manual:Stats for detailed guidance on the conversion process.
https://drive.google.com/file/d/12yQEuOapkML1vb9MgCaX1QzbLBdXE6X2/view for a video tutorial on the conversion process.
https://docs.google.com/presentation/d/1SZWf_D3mWNX-XHN8PHYI84LDZr6GUQC2AMhZ9mQXCI0/edit#slide=id.g2795460c956_0_23 for slides on the best practices for converting metrics to statslib.

  • MediaWiki.global_blocking.get_user_block_db_query.rate
  • MediaWiki.global_blocking.get_user_block.rate

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Replace StatsD with StatsFactoryDreamy Jazzmediawiki/extensions/GlobalBlockingmaster+12 -8
Customize query in gerrit

Related Objects
Search...

Event Timeline

• lmata created this task.Mar 6 2024, 9:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2024, 9:03 PM
• lmata mentioned this in T350592: EPIC: migrate in use metrics and dashboards to statslib.Mar 6 2024, 9:07 PM
Tchanders added a project: Trust and Safety Product Team.May 22 2024, 9:37 AM
Dreamy_Jazz added a project: GlobalBlocking.May 22 2024, 11:39 AM
Dreamy_Jazz added a project: Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)).Jan 13 2025, 2:57 PM
Dreamy_Jazz moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)) board.Jan 20 2025, 3:21 PM
Dreamy_Jazz claimed this task.Jan 20 2025, 3:26 PM
Dreamy_Jazz moved this task from Ready to In Progress on the Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)) board.
Dreamy_Jazz set the point value for this task to 1.
gerritbot added a comment.Jan 20 2025, 3:51 PM

Change #1112781 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Replace StatsD with StatsFactory

https://gerrit.wikimedia.org/r/1112781

gerritbot added a project: Patch-For-Review.Jan 20 2025, 3:51 PM
Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)) board.Jan 20 2025, 3:52 PM
gerritbot added a comment.Jan 21 2025, 11:02 AM

Change #1112781 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Replace StatsD with StatsFactory

https://gerrit.wikimedia.org/r/1112781

Dreamy_Jazz moved this task from Needs Review to Ready on the Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)) board.Jan 21 2025, 11:14 AM

I've not been able to find the associated dashboard, so I've asked how to search for it. Moving this back to Ready.

Maintenance_bot removed a project: Patch-For-Review.Jan 21 2025, 11:31 AM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.14; 2025-01-28).Jan 21 2025, 12:00 PM
colewhite subscribed.EditedJan 21 2025, 3:51 PM

Dashboard appears to be: https://grafana-rw.wikimedia.org/d/000000378/ladsgroup-test

This paste contains an audit of dashboard metrics usage as of Jan 2024: https://phabricator.wikimedia.org/P54551

Dreamy_Jazz added a comment.Jan 23 2025, 2:28 PM
In T359480#10480310, @colewhite wrote:

Dashboard appears to be: https://grafana-rw.wikimedia.org/d/000000378/ladsgroup-test

This paste contains an audit of dashboard metrics usage as of Jan 2024: https://phabricator.wikimedia.org/P54551

Thanks!

Dreamy_Jazz added a comment.EditedJan 23 2025, 2:30 PM

I think Trust and Safety Product Team should probably have a panel for this data, so I'll create one (as it doesn't seem to fit into any of our existing dashboards) when the patch reaches all wikis via the train.

Dreamy_Jazz moved this task from Ready to Done on the Trust and Safety Product Sprint (Sprint Tuba (Jan 20 - Feb 7)) board.Jan 30 2025, 7:18 PM
Dreamy_Jazz closed this task as Resolved.Jan 30 2025, 7:20 PM
Dreamy_Jazz added a subscriber: Ladsgroup.

Created a TSP team miscellaneous dashboard for metrics that don't otherwise fit into other team dashboards. That is displaying data. Upgrading the use of the old metrics in a test dashboard seems out of this ticket's scope. cc @Ladsgroup as this is your test dashboard.

Dreamy_Jazz updated the task description. (Show Details)Jan 30 2025, 7:20 PM
Ladsgroup added a comment.Jan 30 2025, 9:42 PM

Feel free to just delete that thing. I will do it once I find some time.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits