Page MenuHomePhabricator

DiscussionTools: subscribe button is hidden behind collapsed sections
Open, Needs TriagePublicBUG REPORT

Description

The DiscussionTools extension adds a subscribe button on ==Level 2== discussions.

If someone places a level 2 section within a collapsible (mw-collapsible-content) template , such as itwiki's Template:Cassetto or enwiki's Template:Hidden, the subscribe button is not shown at the top of the visible section. The button is instead hidden behind the collapsed template, likely because the extension considers said section as a signed (timestamped) section.

DiscussionTools should probably ignore sections behind mw-collapsible-content and only show the subscribe button on visible sections.


collapsed.png (1×1 px, 395 KB)

  • Expanded template. Note the misplaced (and previously hidden) subscribe button.

expanded.png (1×1 px, 305 KB)

Event Timeline

Titore renamed this task from DiscussionTools: hidden subscribe link in collapsible sections to DiscussionTools: subscribe button is hidden behind collapsed sections.Mar 10 2024, 1:22 AM

The easier fix here is to avoid level 2 headings unless you are starting a new discussion , e.g. by using level 3 instead

I resorted to just use nowikis, but I would call both ways workarounds. While it has been kind of known that collapsed sections are still sections (they do end up in TOCs, after all), I think users do not expect something they put inside a collapsed template to affect the subscribe link visibility.

In that discussion the collapsed part was used to propose the text of a new guideline. Sort of mentioning the text without it taking too much space. I agree this may not not ideal (I would personally put the wikitext inside <pre> tags) or the intended purpose of mw-collapsible-content, but this happens quite enough in discussions, at least on itwiki.

Wrapping the collapsed fragment in <div class="mw-notalk">...</div> or in <blockquote>...</blockquote> (as documented at https://www.mediawiki.org/wiki/Help:DiscussionTools/Magic_words_and_markup) would also make the subscribe button and discussion metadata work as intended.

However, the table of contents and section edit links would still behave in a very confusing way, so I don't recommend that in this case. The nowikis work better.

On English Wikipedia, they have a template for this situation: https://en.wikipedia.org/wiki/Template:Fake_heading. There's also a request for some way to do that in MediaWiki itself in T8575.