Page MenuHomePhabricator

🐣 Validate the contents of the Item's labels, descriptions, and aliases fields
Closed, ResolvedPublic

Description

  • validate what's not covered by the top-level field validation
  • validate the contents of labels, descriptions, and aliases

Event Timeline

Change #1015622 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Validate Item's labels in CreateItem use case

https://gerrit.wikimedia.org/r/1015622

Change #1015640 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: REST: Validate Item's descriptions in CreateItem use case

https://gerrit.wikimedia.org/r/1015640

Change #1015650 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Validate Item's aliases in CreateItem use case

https://gerrit.wikimedia.org/r/1015650

Change #1016309 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Validate Item's statements in CreateItem use case

https://gerrit.wikimedia.org/r/1016309

Change #1016314 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Validate Item's sitelinks in CreateItem use case

https://gerrit.wikimedia.org/r/1016314

Change #1016317 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Add additional body parameteres e2e tests

https://gerrit.wikimedia.org/r/1016317

Change #1016749 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] Make ItemId nullable in getConflictsForItem method

https://gerrit.wikimedia.org/r/1016749

Change #1016750 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Check for sitelink conflicts for the newly created item

https://gerrit.wikimedia.org/r/1016750

Change #1015622 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Validate Item's labels in CreateItem use case

https://gerrit.wikimedia.org/r/1015622

Change #1017424 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: [DNM] Sketch-out of alternative item validation

https://gerrit.wikimedia.org/r/1017424

Change #1018189 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Rename old label and description validation classes

https://gerrit.wikimedia.org/r/1018189

Change #1018196 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Add new item labels and descriptions validation

https://gerrit.wikimedia.org/r/1018196

Change #1018205 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Use the newly created validation classes in creating new item

https://gerrit.wikimedia.org/r/1018205

Change #1015640 abandoned by Muhammad Jaziraly:

[mediawiki/extensions/Wikibase@master] REST: Validate Item's descriptions in CreateItem use case

Reason:

- The new approach is used in I8899c91adf3962bd73e8f62cae41dfe7ff6d7eed

https://gerrit.wikimedia.org/r/1015640

Change #1017424 abandoned by Silvan Heintze:

[mediawiki/extensions/Wikibase@master] REST: Validate labels and descriptions in CreateItem

Reason:

covered by I73b0984165e2545538e75f843a446b8adbd19dbf and follow-ups

https://gerrit.wikimedia.org/r/1017424

Change #1018189 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Rename old label and description validation classes

https://gerrit.wikimedia.org/r/1018189

Change #1018196 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add new item labels and descriptions validation

https://gerrit.wikimedia.org/r/1018196

Change #1018205 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Use the newly created validation classes in creating new item

https://gerrit.wikimedia.org/r/1018205

Change #1019391 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Validate aliases for CreateItem use case

https://gerrit.wikimedia.org/r/1019391

Change #1015650 abandoned by Muhammad Jaziraly:

[mediawiki/extensions/Wikibase@master] REST: Validate Item's aliases in CreateItem use case

Reason:

- moved to I98f02bd7e37ed57797c752c2d1d2567bbcc8981a

https://gerrit.wikimedia.org/r/1015650

Change #1016749 abandoned by Muhammad Jaziraly:

[mediawiki/extensions/Wikibase@master] Make ItemId nullable in getConflictsForItem method

Reason:

- the change is not good enough. Will search for another approach.

https://gerrit.wikimedia.org/r/1016749

Change #1019393 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Add additional body parameteres e2e tests

https://gerrit.wikimedia.org/r/1019393

Change #1016317 abandoned by Muhammad Jaziraly:

[mediawiki/extensions/Wikibase@master] REST: Add additional body parameteres e2e tests

Reason:

- moved to another patch in a new chain: I7d619d0307d4f8634ccdf99365fd2496a40922b9

https://gerrit.wikimedia.org/r/1016317

Change #1019393 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Validate CreateItem edit metadata

https://gerrit.wikimedia.org/r/1019393

Change #1020218 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Validate Item's statements in CreateItem use case

https://gerrit.wikimedia.org/r/1020218

Change #1016309 abandoned by Muhammad Jaziraly:

[mediawiki/extensions/Wikibase@master] REST: Validate Item's statements in CreateItem use case

Reason:

- done in I36eb84448c02d34c75fd56935b900b98f89b6742

https://gerrit.wikimedia.org/r/1016309

Change #1019391 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Validate aliases for CreateItem use case

https://gerrit.wikimedia.org/r/1019391

Change #1016314 abandoned by Muhammad Jaziraly:

[mediawiki/extensions/Wikibase@master] REST: Validate Item's sitelinks in CreateItem use case

Reason:

https://gerrit.wikimedia.org/r/1016314

Change #1016750 abandoned by Muhammad Jaziraly:

[mediawiki/extensions/Wikibase@master] REST: Check for sitelink conflicts for the newly created item

Reason:

- replaced by I673af1b06a7ec086627f9749056b683f344dfe23

https://gerrit.wikimedia.org/r/1016750

Ollie.Shotton_WMDE renamed this task from 🐣 Validate each item field's contents to 🐣 Validate the contents of the Item's labels, descriptions, and aliases fields.Apr 22 2024, 2:09 PM
Ollie.Shotton_WMDE updated the task description. (Show Details)
Ollie.Shotton_WMDE removed a subscriber: Jakob_WMDE.