Page MenuHomePhabricator
Create Task
Maniphest T359848

🐣 Validate the contents of the Item's labels, descriptions, and aliases fields
Closed, ResolvedPublic
Actions

Description

  • validate what's not covered by the top-level field validation
  • validate the contents of labels, descriptions, and aliases

Details

Other Assignee
Ollie.Shotton_WMDE
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.Mar 11 2024, 3:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 11 2024, 3:12 PM
Ifrahkhanyaree_WMDE moved this task from Sprint 15 to Sprint 16 on the Wikibase Product Platform Team WPP board.Mar 19 2024, 2:18 PM
Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 16); removed Wikibase Product Platform Team WPP (Sprint 15).
Muhammad_Yasser_Jazirahly_WMDE claimed this task.Mar 24 2024, 9:02 AM
Muhammad_Yasser_Jazirahly_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 16) board.
gerritbot added a comment.Mar 30 2024, 3:30 PM

Change #1015622 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Validate Item's labels in CreateItem use case

https://gerrit.wikimedia.org/r/1015622

gerritbot added a project: Patch-For-Review.Mar 30 2024, 3:30 PM
gerritbot added a comment.Mar 31 2024, 10:01 AM

Change #1015640 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: REST: Validate Item's descriptions in CreateItem use case

https://gerrit.wikimedia.org/r/1015640

gerritbot added a comment.Mar 31 2024, 8:01 PM

Change #1015650 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Validate Item's aliases in CreateItem use case

https://gerrit.wikimedia.org/r/1015650

Ifrahkhanyaree_WMDE moved this task from Sprint 16 to Sprint 17 on the Wikibase Product Platform Team WPP board.Apr 2 2024, 10:01 AM
Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 17); removed Wikibase Product Platform Team WPP (Sprint 16).
Ifrahkhanyaree_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 17) board.
gerritbot added a comment.Apr 2 2024, 10:36 AM

Change #1016309 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Validate Item's statements in CreateItem use case

https://gerrit.wikimedia.org/r/1016309

gerritbot added a comment.Apr 2 2024, 11:13 AM

Change #1016314 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Validate Item's sitelinks in CreateItem use case

https://gerrit.wikimedia.org/r/1016314

gerritbot added a comment.Apr 2 2024, 11:25 AM

Change #1016317 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Add additional body parameteres e2e tests

https://gerrit.wikimedia.org/r/1016317

gerritbot added a comment.Apr 3 2024, 11:33 AM

Change #1016749 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] Make ItemId nullable in getConflictsForItem method

https://gerrit.wikimedia.org/r/1016749

gerritbot added a comment.Apr 3 2024, 11:33 AM

Change #1016750 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Check for sitelink conflicts for the newly created item

https://gerrit.wikimedia.org/r/1016750

Muhammad_Yasser_Jazirahly_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 17) board.Apr 3 2024, 12:05 PM
gerritbot added a comment.Apr 4 2024, 3:07 PM

Change #1015622 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Validate Item's labels in CreateItem use case

https://gerrit.wikimedia.org/r/1015622

gerritbot added a comment.Apr 6 2024, 7:55 AM

Change #1017424 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: [DNM] Sketch-out of alternative item validation

https://gerrit.wikimedia.org/r/1017424

Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Doing on the Wikibase Product Platform Team WPP (Sprint 17) board.Apr 9 2024, 8:23 AM
gerritbot added a comment.Apr 9 2024, 8:24 AM

Change #1018189 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Rename old label and description validation classes

https://gerrit.wikimedia.org/r/1018189

gerritbot added a comment.Apr 9 2024, 8:52 AM

Change #1018196 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Add new item labels and descriptions validation

https://gerrit.wikimedia.org/r/1018196

gerritbot added a comment.Apr 9 2024, 9:57 AM

Change #1018205 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Use the newly created validation classes in creating new item

https://gerrit.wikimedia.org/r/1018205

gerritbot added a comment.Apr 9 2024, 11:51 AM

Change #1015640 abandoned by Muhammad Jaziraly:

[mediawiki/extensions/Wikibase@master] REST: Validate Item's descriptions in CreateItem use case

Reason:

- The new approach is used in I8899c91adf3962bd73e8f62cae41dfe7ff6d7eed

https://gerrit.wikimedia.org/r/1015640

gerritbot added a comment.Apr 9 2024, 2:02 PM

Change #1017424 abandoned by Silvan Heintze:

[mediawiki/extensions/Wikibase@master] REST: Validate labels and descriptions in CreateItem

Reason:

covered by I73b0984165e2545538e75f843a446b8adbd19dbf and follow-ups

https://gerrit.wikimedia.org/r/1017424

Silvan_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 17) board.Apr 11 2024, 1:16 PM
gerritbot added a comment.Apr 13 2024, 9:21 AM

Change #1018189 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Rename old label and description validation classes

https://gerrit.wikimedia.org/r/1018189

gerritbot added a comment.Apr 13 2024, 9:26 AM

Change #1018196 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add new item labels and descriptions validation

https://gerrit.wikimedia.org/r/1018196

gerritbot added a comment.Apr 13 2024, 9:55 AM

Change #1018205 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Use the newly created validation classes in creating new item

https://gerrit.wikimedia.org/r/1018205

gerritbot added a comment.Apr 13 2024, 4:48 PM

Change #1019391 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Validate aliases for CreateItem use case

https://gerrit.wikimedia.org/r/1019391

gerritbot added a comment.Apr 13 2024, 5:14 PM

Change #1015650 abandoned by Muhammad Jaziraly:

[mediawiki/extensions/Wikibase@master] REST: Validate Item's aliases in CreateItem use case

Reason:

- moved to I98f02bd7e37ed57797c752c2d1d2567bbcc8981a

https://gerrit.wikimedia.org/r/1015650

gerritbot added a comment.Apr 13 2024, 5:16 PM

Change #1016749 abandoned by Muhammad Jaziraly:

[mediawiki/extensions/Wikibase@master] Make ItemId nullable in getConflictsForItem method

Reason:

- the change is not good enough. Will search for another approach.

https://gerrit.wikimedia.org/r/1016749

gerritbot added a comment.Apr 13 2024, 5:20 PM

Change #1019393 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Add additional body parameteres e2e tests

https://gerrit.wikimedia.org/r/1019393

gerritbot added a comment.Apr 13 2024, 5:21 PM

Change #1016317 abandoned by Muhammad Jaziraly:

[mediawiki/extensions/Wikibase@master] REST: Add additional body parameteres e2e tests

Reason:

- moved to another patch in a new chain: I7d619d0307d4f8634ccdf99365fd2496a40922b9

https://gerrit.wikimedia.org/r/1016317

Silvan_WMDE moved this task from Peer Review to Doing on the Wikibase Product Platform Team WPP (Sprint 17) board.Apr 15 2024, 9:14 AM
gerritbot added a comment.Apr 16 2024, 2:44 AM

Change #1019393 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Validate CreateItem edit metadata

https://gerrit.wikimedia.org/r/1019393

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).Apr 16 2024, 3:00 AM
Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 18); removed Wikibase Product Platform Team WPP (Sprint 17).Apr 16 2024, 10:21 AM
Ifrahkhanyaree_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 18) board.
Muhammad_Yasser_Jazirahly_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 18) board.Apr 16 2024, 11:02 AM
gerritbot added a comment.Apr 16 2024, 1:44 PM

Change #1020218 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Validate Item's statements in CreateItem use case

https://gerrit.wikimedia.org/r/1020218

gerritbot added a comment.Apr 17 2024, 11:24 AM

Change #1016309 abandoned by Muhammad Jaziraly:

[mediawiki/extensions/Wikibase@master] REST: Validate Item's statements in CreateItem use case

Reason:

- done in I36eb84448c02d34c75fd56935b900b98f89b6742

https://gerrit.wikimedia.org/r/1016309

Ollie.Shotton_WMDE updated Other Assignee, added: Ollie.Shotton_WMDE.Apr 19 2024, 11:31 AM
gerritbot added a comment.Apr 19 2024, 5:42 PM

Change #1019391 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Validate aliases for CreateItem use case

https://gerrit.wikimedia.org/r/1019391

gerritbot added a comment.Apr 22 2024, 12:35 PM

Change #1016314 abandoned by Muhammad Jaziraly:

[mediawiki/extensions/Wikibase@master] REST: Validate Item's sitelinks in CreateItem use case

Reason:

https://gerrit.wikimedia.org/r/1016314

gerritbot added a comment.Apr 22 2024, 12:36 PM

Change #1016750 abandoned by Muhammad Jaziraly:

[mediawiki/extensions/Wikibase@master] REST: Check for sitelink conflicts for the newly created item

Reason:

- replaced by I673af1b06a7ec086627f9749056b683f344dfe23

https://gerrit.wikimedia.org/r/1016750

Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 18) board.Apr 22 2024, 12:57 PM
Ollie.Shotton_WMDE renamed this task from 🐣 Validate each item field's contents to 🐣 Validate the contents of the Item's labels, descriptions, and aliases fields.Apr 22 2024, 2:09 PM
Ollie.Shotton_WMDE updated the task description. (Show Details)
Ollie.Shotton_WMDE removed a subtask: T362603: 🐣 Validate statements for Create Item.
Ollie.Shotton_WMDE removed a subtask: T362604: 🐣 Validate sitelinks for Create Item.
Ollie.Shotton_WMDE removed a project: Patch-For-Review.
Ollie.Shotton_WMDE removed a subscriber: Jakob_WMDE.
Ifrahkhanyaree_WMDE closed this task as Resolved.Apr 30 2024, 10:58 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits