Maniphest T359872

Resolve Code Objects Ephemerally
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cmassaro
	Mar 11 2024, 5:18 PM

Tags

Referenced Files

None

Subscribers

Description

Description

In src/implementation.js, we call resolveKey and asJSON to prepare an object to be sent to the evaluator. We could instead use resolveEphemeral and asJSONEphemeral. This would result in cleaner output for the API.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

use resolveEphemeral to prepare objects for the evaluator

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Back-end_Task/Bug_completion_checklist

Details

	Subject	Repo	Branch	Lines +/-
	wikifunctions: Upgrade orchestrator from 2024-03-05-140533 to 2024-04-04-132719	operations/deployment-charts	master	+1 -1

Customize query in gerrit

	Title	Reference	Author	Source Branch	Dest Branch
	Resolve implementation internals ephemerally and do some minor cleanup.	repos/abstract-wiki/wikifunctions/function-orchestrator!148	apine	apine-ephemeral-code-objects	main

Customize query in GitLab

Event Timeline

cmassaro created this task.Mar 11 2024, 5:18 PM

Mcastro triaged this task as Medium priority.Mar 14 2024, 4:50 PM

Mcastro moved this task from To triage to Backlog on the Abstract Wikipedia team board.

cmassaro changed the task status from Open to In Progress.Mar 20 2024, 6:05 PM

cmassaro claimed this task.

cmassaro moved this task from Backlog to In Progress on the Abstract Wikipedia team board.

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/148

Resolve implementation internals ephemerally and do some minor cleanup.

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/148

Resolve implementation internals ephemerally and do some minor cleanup.

Maintenance_bot removed a project: Patch-For-Review.Thu, Apr 4, 1:30 PM

Change #1017060 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-03-05-140533 to 2024-04-04-132719

https://gerrit.wikimedia.org/r/1017060

gerritbot added a project: Patch-For-Review.Thu, Apr 4, 1:44 PM

Change #1017060 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-03-05-140533 to 2024-04-04-132719

https://gerrit.wikimedia.org/r/1017060

Jdforrester-WMF moved this task from In Progress to Verify in production on the Abstract Wikipedia team board.Thu, Apr 4, 4:08 PM

Jdforrester-WMF closed this task as Resolved.Thu, Apr 4, 7:56 PM