Page MenuHomePhabricator

Reload button appears on top of VE switcher menu
Closed, ResolvedPublicBUG REPORT

Description

When RealtimePreview is open, and the VisualEditor mode-switch menu is opened, when the cursor is moved over the RTP pane the 'Reload' button is on top of the mode-switch menu:

button over menu.png (175×258 px, 10 KB)

Event Timeline

This doesn't appear to happen consistently for me locally:

image.png (270×446 px, 30 KB)

There's a rule in CodeMirror (written by myself 5 years ago) that gives the toolbar a z-index of 7, so this is only broken when CodeMirror is not installed.

We should probably upstream that rule to WikiEditor.

Change 1011016 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/WikiEditor@master] Set toolbar z-index to 7, to be above other UI elements

https://gerrit.wikimedia.org/r/1011016

Change 1011153 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/CodeMirror@master] Remove WikiEditor toolbar z-index override

https://gerrit.wikimedia.org/r/1011153

Change 1011016 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Set toolbar z-index to 7, to be above other UI elements

https://gerrit.wikimedia.org/r/1011016

Change 1011153 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Remove WikiEditor toolbar z-index override

https://gerrit.wikimedia.org/r/1011153

Samwilson claimed this task.

All sorted I think. Thanks!