Page MenuHomePhabricator

Make the cupe_actor column nullable on WMF wikis
Closed, ResolvedPublic

Description

The cupe_actor column of the cu_private_event table was made nullable to prevent the need to acquire an actor ID for an IP address when temporary accounts are enabled. This was recommended over using a new table by @Ladsgroup in T359309#9615111.

  1. ALTERs to run: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CheckUser/+/0aafa1d1d990f6cabccf67e339ea46d360cdb158/schema/mysql/patch-cu_private_event-modify-cupe_actor-nullable.sql
  2. Where to run those changes: all
  3. When to run those changes: Ideally sooner than later as this blocks a testwiki deploy of temporary accounts
  4. If the schema change is backwards compatible: Yes.
  5. If the schema change has been tested already on some of the test/beta wikis: checkuser is not on beta cluster but has been deployed on a mwvagrant instance on https://checkuser-beta-wiki.wmcloud.org
  6. If the data should be made available on the labs replicas and/or dumps: Everything is private
  • s1
  • s2
  • s3
  • s4
  • s5
  • s6
  • s7
  • s8

Details

Related Changes in Gerrit:
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
schema update: T360332repos/sre/schema-changes!8arnaudbtask/T360332main
Customize query in GitLab

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

@ABran-WMF I switched s2 master a few days ago (T362036) - check if you need/can run this schema change on the OLD master.

Mentioned in SAL (#wikimedia-operations) [2024-04-16T14:28:09Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db1244 (T360332)', diff saved to https://phabricator.wikimedia.org/P60624 and previous config saved to /var/cache/conftool/dbconfig/20240416-142808-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-04-16T14:31:27Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db1244 (T360332)', diff saved to https://phabricator.wikimedia.org/P60626 and previous config saved to /var/cache/conftool/dbconfig/20240416-143126-arnaudb.json

@ABran-WMF I switched s2 master a few days ago (T362036) - check if you need/can run this schema change on the OLD master.

This same applies to s3 codfw master, which I just switched T362616

Mentioned in SAL (#wikimedia-operations) [2024-04-16T15:16:50Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db1244 (T360332)', diff saved to https://phabricator.wikimedia.org/P60642 and previous config saved to /var/cache/conftool/dbconfig/20240416-151649-arnaudb.json

ABran-WMF updated the task description. (Show Details)

Mentioned in SAL (#wikimedia-operations) [2024-04-17T15:17:12Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db2127 (T360332)', diff saved to https://phabricator.wikimedia.org/P60792 and previous config saved to /var/cache/conftool/dbconfig/20240417-151653-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-04-17T15:32:38Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2127 (T360332)', diff saved to https://phabricator.wikimedia.org/P60795 and previous config saved to /var/cache/conftool/dbconfig/20240417-153238-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-04-17T16:35:06Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2127 (T360332)', diff saved to https://phabricator.wikimedia.org/P60801 and previous config saved to /var/cache/conftool/dbconfig/20240417-163506-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-04-30T08:27:53Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db2121 (T360332)', diff saved to https://phabricator.wikimedia.org/P61467 and previous config saved to /var/cache/conftool/dbconfig/20240430-082753-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-04-30T08:30:34Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2121 (T360332)', diff saved to https://phabricator.wikimedia.org/P61468 and previous config saved to /var/cache/conftool/dbconfig/20240430-083033-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-04-30T09:10:02Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db2179 (T360332)', diff saved to https://phabricator.wikimedia.org/P61479 and previous config saved to /var/cache/conftool/dbconfig/20240430-091002-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-04-30T09:12:22Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2179 (T360332)', diff saved to https://phabricator.wikimedia.org/P61481 and previous config saved to /var/cache/conftool/dbconfig/20240430-091221-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-04-30T09:15:56Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2121 (T360332)', diff saved to https://phabricator.wikimedia.org/P61482 and previous config saved to /var/cache/conftool/dbconfig/20240430-091556-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-04-30T09:57:46Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2179 (T360332)', diff saved to https://phabricator.wikimedia.org/P61488 and previous config saved to /var/cache/conftool/dbconfig/20240430-095745-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-05-13T12:59:40Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db2165 (T360332)', diff saved to https://phabricator.wikimedia.org/P62354 and previous config saved to /var/cache/conftool/dbconfig/20240513-125940-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-05-13T13:00:50Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db1181 (T360332)', diff saved to https://phabricator.wikimedia.org/P62355 and previous config saved to /var/cache/conftool/dbconfig/20240513-130049-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-05-13T13:01:59Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2165 (T360332)', diff saved to https://phabricator.wikimedia.org/P62356 and previous config saved to /var/cache/conftool/dbconfig/20240513-130158-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-05-13T13:03:30Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db1181 (T360332)', diff saved to https://phabricator.wikimedia.org/P62357 and previous config saved to /var/cache/conftool/dbconfig/20240513-130329-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-05-13T13:47:24Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2165 (T360332)', diff saved to https://phabricator.wikimedia.org/P62362 and previous config saved to /var/cache/conftool/dbconfig/20240513-134721-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-05-13T13:48:53Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db1181 (T360332)', diff saved to https://phabricator.wikimedia.org/P62363 and previous config saved to /var/cache/conftool/dbconfig/20240513-134852-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-05-16T07:23:55Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db1173 (T360332)', diff saved to https://phabricator.wikimedia.org/P62446 and previous config saved to /var/cache/conftool/dbconfig/20240516-072355-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-05-16T07:26:14Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db1173 (T360332)', diff saved to https://phabricator.wikimedia.org/P62448 and previous config saved to /var/cache/conftool/dbconfig/20240516-072614-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-05-16T08:11:36Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db1173 (T360332)', diff saved to https://phabricator.wikimedia.org/P62462 and previous config saved to /var/cache/conftool/dbconfig/20240516-081136-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-05-27T14:19:49Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db1238 (T360332)', diff saved to https://phabricator.wikimedia.org/P63322 and previous config saved to /var/cache/conftool/dbconfig/20240527-141948-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-05-27T14:22:11Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db1238 (T360332)', diff saved to https://phabricator.wikimedia.org/P63324 and previous config saved to /var/cache/conftool/dbconfig/20240527-142210-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-05-27T15:07:35Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db1238 (T360332)', diff saved to https://phabricator.wikimedia.org/P63332 and previous config saved to /var/cache/conftool/dbconfig/20240527-150735-arnaudb.json

s8 eqiad master was switched today.

But please coordinate with me first, as I am running stuff in there today

sure, let me know when you're done :)

looks like db2205 already had the schema change:

Result: {"already done in all dbs": ["db2205"]}

I've also --check-ed both masters on s3:

Result: {"already done in all dbs": ["db1223", "db2127"]}

So that makes s3 done.

Mentioned in SAL (#wikimedia-operations) [2024-06-06T14:49:44Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db1209 (T360332)', diff saved to https://phabricator.wikimedia.org/P64185 and previous config saved to /var/cache/conftool/dbconfig/20240606-144943-arnaudb.json

s2 masters are the 2 only hosts left.

Mentioned in SAL (#wikimedia-operations) [2024-06-06T14:52:07Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db1209 (T360332)', diff saved to https://phabricator.wikimedia.org/P64186 and previous config saved to /var/cache/conftool/dbconfig/20240606-145205-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-06-06T15:37:31Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db1209 (T360332)', diff saved to https://phabricator.wikimedia.org/P64195 and previous config saved to /var/cache/conftool/dbconfig/20240606-153730-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-06-11T09:25:04Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db1222 (T360332)', diff saved to https://phabricator.wikimedia.org/P64602 and previous config saved to /var/cache/conftool/dbconfig/20240611-092504-arnaudb.json

Mentioned in SAL (#wikimedia-operations) [2024-06-11T09:28:40Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db1222 (T360332)', diff saved to https://phabricator.wikimedia.org/P64603 and previous config saved to /var/cache/conftool/dbconfig/20240611-092839-arnaudb.json

ABran-WMF moved this task from In progress to Done on the DBA board.

Mentioned in SAL (#wikimedia-operations) [2024-06-11T10:14:01Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db1222 (T360332)', diff saved to https://phabricator.wikimedia.org/P64606 and previous config saved to /var/cache/conftool/dbconfig/20240611-101400-arnaudb.json

It was missed in db2203. I ran it there.