Page MenuHomePhabricator
Create Task
Maniphest T360332

Make the cupe_actor column nullable on WMF wikis
Open, In Progress, MediumPublic
Actions

Description

The cupe_actor column of the cu_private_event table was made nullable to prevent the need to acquire an actor ID for an IP address when temporary accounts are enabled. This was recommended over using a new table by @Ladsgroup in T359309#9615111.

  1. ALTERs to run: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CheckUser/+/0aafa1d1d990f6cabccf67e339ea46d360cdb158/schema/mysql/patch-cu_private_event-modify-cupe_actor-nullable.sql
  2. Where to run those changes: all
  3. When to run those changes: Ideally sooner than later as this blocks a testwiki deploy of temporary accounts
  4. If the schema change is backwards compatible: Yes.
  5. If the schema change has been tested already on some of the test/beta wikis: checkuser is not on beta cluster but has been deployed on a mwvagrant instance on https://checkuser-beta-wiki.wmcloud.org
  6. If the data should be made available on the labs replicas and/or dumps: Everything is private
  • s1 done except for dc-masters
  • s2 done except for dc-masters
  • s3 done except for dc-masters
  • s4 done except for dc-master eqiad
  • s5
  • s6 done except for dc-master eqiad
  • s7 done except for dc-master eqiad
  • s8 done except for dc-masters

Details

SubjectRepoBranchLines +/-
auto_schema: add a test on Db to check column typesoperations/softwaremaster+18 -0
Customize query in gerrit
TitleReferenceAuthorSource BranchDest Branch
schema update: T360332repos/sre/schema-changes!8arnaudbtask/T360332main
Customize query in GitLab

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
OpenDreamy_JazzT353953 Don't use actor IDs for private CheckUser events when these actions are performed by IP addresses
In ProgressABran-WMFT360332 Make the cupe_actor column nullable on WMF wikis
ResolvedDreamy_JazzT359873 Make the cupe_private column nullable
· · ·

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Stashbot added a comment.Wed, Apr 10, 10:20 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-10T22:20:29Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2130 (T360332)', diff saved to https://phabricator.wikimedia.org/P60306 and previous config saved to /var/cache/conftool/dbconfig/20240410-222028-arnaudb.json

Stashbot added a comment.Wed, Apr 10, 10:21 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-10T22:21:51Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db2145 (T360332)', diff saved to https://phabricator.wikimedia.org/P60307 and previous config saved to /var/cache/conftool/dbconfig/20240410-222150-arnaudb.json

Stashbot added a comment.Wed, Apr 10, 10:24 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-10T22:24:46Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2145 (T360332)', diff saved to https://phabricator.wikimedia.org/P60308 and previous config saved to /var/cache/conftool/dbconfig/20240410-222445-arnaudb.json

Stashbot added a comment.Wed, Apr 10, 11:10 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-10T23:10:08Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2145 (T360332)', diff saved to https://phabricator.wikimedia.org/P60311 and previous config saved to /var/cache/conftool/dbconfig/20240410-231008-arnaudb.json

Stashbot added a comment.Wed, Apr 10, 11:10 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-10T23:10:32Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db2146 (T360332)', diff saved to https://phabricator.wikimedia.org/P60312 and previous config saved to /var/cache/conftool/dbconfig/20240410-231032-arnaudb.json

Stashbot added a comment.Wed, Apr 10, 11:13 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-10T23:13:35Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2146 (T360332)', diff saved to https://phabricator.wikimedia.org/P60313 and previous config saved to /var/cache/conftool/dbconfig/20240410-231335-arnaudb.json

Stashbot added a comment.Wed, Apr 10, 11:58 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-10T23:58:58Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2146 (T360332)', diff saved to https://phabricator.wikimedia.org/P60316 and previous config saved to /var/cache/conftool/dbconfig/20240410-235857-arnaudb.json

Stashbot added a comment.Wed, Apr 10, 11:59 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-10T23:59:21Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db2153 (T360332)', diff saved to https://phabricator.wikimedia.org/P60317 and previous config saved to /var/cache/conftool/dbconfig/20240410-235920-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 12:02 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T00:02:11Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2153 (T360332)', diff saved to https://phabricator.wikimedia.org/P60319 and previous config saved to /var/cache/conftool/dbconfig/20240411-000211-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 12:47 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T00:47:35Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2153 (T360332)', diff saved to https://phabricator.wikimedia.org/P60326 and previous config saved to /var/cache/conftool/dbconfig/20240411-004735-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 12:47 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T00:47:58Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db2170 (T360332)', diff saved to https://phabricator.wikimedia.org/P60327 and previous config saved to /var/cache/conftool/dbconfig/20240411-004758-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 12:50 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T00:50:54Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2170 (T360332)', diff saved to https://phabricator.wikimedia.org/P60328 and previous config saved to /var/cache/conftool/dbconfig/20240411-005054-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 1:36 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T01:36:19Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2170 (T360332)', diff saved to https://phabricator.wikimedia.org/P60331 and previous config saved to /var/cache/conftool/dbconfig/20240411-013618-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 1:36 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T01:36:58Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db2173 (T360332)', diff saved to https://phabricator.wikimedia.org/P60332 and previous config saved to /var/cache/conftool/dbconfig/20240411-013657-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 1:38 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T01:38:48Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2173 (T360332)', diff saved to https://phabricator.wikimedia.org/P60333 and previous config saved to /var/cache/conftool/dbconfig/20240411-013848-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 2:24 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T02:24:11Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2173 (T360332)', diff saved to https://phabricator.wikimedia.org/P60339 and previous config saved to /var/cache/conftool/dbconfig/20240411-022410-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 2:24 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T02:24:44Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db2174 (T360332)', diff saved to https://phabricator.wikimedia.org/P60340 and previous config saved to /var/cache/conftool/dbconfig/20240411-022433-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 2:27 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T02:27:25Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2174 (T360332)', diff saved to https://phabricator.wikimedia.org/P60341 and previous config saved to /var/cache/conftool/dbconfig/20240411-022725-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 3:12 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T03:12:48Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2174 (T360332)', diff saved to https://phabricator.wikimedia.org/P60345 and previous config saved to /var/cache/conftool/dbconfig/20240411-031247-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 3:13 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T03:13:11Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db2176 (T360332)', diff saved to https://phabricator.wikimedia.org/P60346 and previous config saved to /var/cache/conftool/dbconfig/20240411-031310-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 3:16 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T03:16:02Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2176 (T360332)', diff saved to https://phabricator.wikimedia.org/P60347 and previous config saved to /var/cache/conftool/dbconfig/20240411-031602-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 4:01 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T04:01:25Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2176 (T360332)', diff saved to https://phabricator.wikimedia.org/P60350 and previous config saved to /var/cache/conftool/dbconfig/20240411-040124-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 4:01 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T04:01:51Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db2188 (T360332)', diff saved to https://phabricator.wikimedia.org/P60351 and previous config saved to /var/cache/conftool/dbconfig/20240411-040147-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 4:04 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T04:04:47Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2188 (T360332)', diff saved to https://phabricator.wikimedia.org/P60352 and previous config saved to /var/cache/conftool/dbconfig/20240411-040447-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 4:50 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T04:50:12Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2188 (T360332)', diff saved to https://phabricator.wikimedia.org/P60355 and previous config saved to /var/cache/conftool/dbconfig/20240411-045011-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 4:50 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T04:50:29Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db2212 (T360332)', diff saved to https://phabricator.wikimedia.org/P60356 and previous config saved to /var/cache/conftool/dbconfig/20240411-045024-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 4:53 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T04:53:18Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2212 (T360332)', diff saved to https://phabricator.wikimedia.org/P60357 and previous config saved to /var/cache/conftool/dbconfig/20240411-045317-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 5:38 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T05:38:41Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2212 (T360332)', diff saved to https://phabricator.wikimedia.org/P60361 and previous config saved to /var/cache/conftool/dbconfig/20240411-053840-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 5:39 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T05:39:04Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db2216 (T360332)', diff saved to https://phabricator.wikimedia.org/P60362 and previous config saved to /var/cache/conftool/dbconfig/20240411-053903-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 5:42 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T05:42:05Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2216 (T360332)', diff saved to https://phabricator.wikimedia.org/P60363 and previous config saved to /var/cache/conftool/dbconfig/20240411-054205-arnaudb.json

Stashbot added a comment.Thu, Apr 11, 6:27 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T06:27:28Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2216 (T360332)', diff saved to https://phabricator.wikimedia.org/P60369 and previous config saved to /var/cache/conftool/dbconfig/20240411-062728-arnaudb.json

ABran-WMF updated the task description. (Show Details)Thu, Apr 11, 8:40 AM
Stashbot added a comment.Thu, Apr 11, 9:26 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-11T09:26:23Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db1165 (T360332)', diff saved to https://phabricator.wikimedia.org/P60382 and previous config saved to /var/cache/conftool/dbconfig/20240411-092622-arnaudb.json

ABran-WMF updated the task description. (Show Details)Thu, Apr 11, 9:38 AM
Marostegui added a comment.Sat, Apr 13, 6:09 AM

@ABran-WMF I switched s2 master a few days ago (T362036) - check if you need/can run this schema change on the OLD master.

Stashbot added a comment.Tue, Apr 16, 2:28 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-16T14:28:09Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db1244 (T360332)', diff saved to https://phabricator.wikimedia.org/P60624 and previous config saved to /var/cache/conftool/dbconfig/20240416-142808-arnaudb.json

Stashbot added a comment.Tue, Apr 16, 2:31 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-16T14:31:27Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db1244 (T360332)', diff saved to https://phabricator.wikimedia.org/P60626 and previous config saved to /var/cache/conftool/dbconfig/20240416-143126-arnaudb.json

Marostegui added a comment.Tue, Apr 16, 3:15 PM
In T360332#9711388, @Marostegui wrote:

@ABran-WMF I switched s2 master a few days ago (T362036) - check if you need/can run this schema change on the OLD master.

This same applies to s3 codfw master, which I just switched T362616

Stashbot added a comment.Tue, Apr 16, 3:16 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-16T15:16:50Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db1244 (T360332)', diff saved to https://phabricator.wikimedia.org/P60642 and previous config saved to /var/cache/conftool/dbconfig/20240416-151649-arnaudb.json

ABran-WMF updated the task description. (Show Details)Tue, Apr 16, 4:07 PM
ABran-WMF updated the task description. (Show Details)
Stashbot added a comment.Wed, Apr 17, 3:17 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-17T15:17:12Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db2127 (T360332)', diff saved to https://phabricator.wikimedia.org/P60792 and previous config saved to /var/cache/conftool/dbconfig/20240417-151653-arnaudb.json

Stashbot added a comment.Wed, Apr 17, 3:32 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-17T15:32:38Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2127 (T360332)', diff saved to https://phabricator.wikimedia.org/P60795 and previous config saved to /var/cache/conftool/dbconfig/20240417-153238-arnaudb.json

Stashbot added a comment.Wed, Apr 17, 4:35 PM

Mentioned in SAL (#wikimedia-operations) [2024-04-17T16:35:06Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2127 (T360332)', diff saved to https://phabricator.wikimedia.org/P60801 and previous config saved to /var/cache/conftool/dbconfig/20240417-163506-arnaudb.json

ABran-WMF updated the task description. (Show Details)Thu, Apr 18, 6:40 AM
Marostegui added a comment.Mon, Apr 29, 9:26 AM

s7 master codfw switched.

Marostegui added a comment.Tue, Apr 30, 5:23 AM

s3 eqiad master switched

Stashbot added a comment.Tue, Apr 30, 8:27 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-30T08:27:53Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db2121 (T360332)', diff saved to https://phabricator.wikimedia.org/P61467 and previous config saved to /var/cache/conftool/dbconfig/20240430-082753-arnaudb.json

Stashbot added a comment.Tue, Apr 30, 8:30 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-30T08:30:34Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2121 (T360332)', diff saved to https://phabricator.wikimedia.org/P61468 and previous config saved to /var/cache/conftool/dbconfig/20240430-083033-arnaudb.json

ABran-WMF updated the task description. (Show Details)Tue, Apr 30, 9:02 AM
Stashbot added a comment.Tue, Apr 30, 9:10 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-30T09:10:02Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Depooling db2179 (T360332)', diff saved to https://phabricator.wikimedia.org/P61479 and previous config saved to /var/cache/conftool/dbconfig/20240430-091002-arnaudb.json

Stashbot added a comment.Tue, Apr 30, 9:12 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-30T09:12:22Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2179 (T360332)', diff saved to https://phabricator.wikimedia.org/P61481 and previous config saved to /var/cache/conftool/dbconfig/20240430-091221-arnaudb.json

Stashbot added a comment.Tue, Apr 30, 9:15 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-30T09:15:56Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2121 (T360332)', diff saved to https://phabricator.wikimedia.org/P61482 and previous config saved to /var/cache/conftool/dbconfig/20240430-091556-arnaudb.json

Stashbot added a comment.Tue, Apr 30, 9:57 AM

Mentioned in SAL (#wikimedia-operations) [2024-04-30T09:57:46Z] <arnaudb@cumin1002> dbctl commit (dc=all): 'Repooling after maintenance db2179 (T360332)', diff saved to https://phabricator.wikimedia.org/P61488 and previous config saved to /var/cache/conftool/dbconfig/20240430-095745-arnaudb.json

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL