Null not handled properly
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	alex-mashin
	Mar 19 2024, 1:58 AM

Description

Setup:

MediaWiki 1.39.6 (0e03068) 2024-03-11T16:26:30
PHP 8.1.2-1ubuntu2.14 (apache2handler)
MariaDB 10.6.16-MariaDB-0ubuntu0.22.04.1
External Data 3.4-alpha (20a6b7f) 2024-03-15T09:43:16

Issue:

{{#display_external_table:
   source=https://example.org/w/images/9/9c/Export_slice_123.csv
  |format=CSV with header
  |header lines=1
  |start line=3
  |end line=10
  |data= mynr=recordnumber, priref=orig_performance_ref, pc=productcode
  |template=Test Template
}}
|}

Deprecated : strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in /../w/extensions/ExternalData/includes/EDParsesParams.php on line 117

Source: https://www.mediawiki.org/w/index.php?title=Extension_talk%3AExternal_Data&wvprov=sticky-header#Deprecated_:_strtolower():_Passing_null_to_parameter_#1_($string)_of_type_string_is_deprecated

Details

	Subject	Repo	Branch	Lines +/-
	Assume that the standalone mode emulates {{#get_external_data:}}	mediawiki/extensions/ExternalData	master	+14 -3

Customize query in gerrit

Event Timeline

alex-mashin created this task.Mar 19 2024, 1:58 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2024, 1:58 AM

alex-mashin claimed this task.Mar 19 2024, 1:59 AM

alex-mashin triaged this task as Medium priority.

Change 1012461 had a related patch set uploaded (by Alex Mashin; author: mashin):

[mediawiki/extensions/ExternalData@master] Assume that the standalone mode emulates {{#get_external_data:}}

https://gerrit.wikimedia.org/r/1012461

gerritbot added a project: Patch-For-Review.Mar 19 2024, 2:31 AM

Change 1012461 merged by jenkins-bot:

[mediawiki/extensions/ExternalData@master] Assume that the standalone mode emulates {{#get_external_data:}}

https://gerrit.wikimedia.org/r/1012461

Maintenance_bot removed a project: Patch-For-Review.Mar 19 2024, 3:30 AM

Kghbln added a comment.Mar 19 2024, 5:10 PM

This comment was removed by Kghbln.

Could it be that that's just a file permissions problem? I don't see how any of the recent changes to External Data would cause that error. The fact that the Data Transfer extension gives the same error also seems very suspicious.

It looks like the error went away. Thanks.

You were to fast responding. Somehow I pulled the code it the wrong extension directory. Senior moments.

Kghbln closed this task as Resolved.Mar 19 2024, 5:16 PM

That's great to hear!

Null not handled properlyClosed, ResolvedPublicBUG REPORTActions

Description

Details

Event Timeline

Null not handled properly
Closed, ResolvedPublicBUG REPORT
Actions