styles: remove spacing on cdx-field links
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	lwatson
	Mar 25 2024, 8:52 PM

Description

We recently added margin-top to all elements with class cdx-field in T358827. This change introduced spacing between links within the Log in form on Special:UserLogin. These links are nested inside HTMLInfoField with the class cdx-field.

The HTMLInfoField within the Log In form already had margin-top and margin-bottom of 0.5em before. Now there's an additional margin-top: 24px;.

This was discovered from a regression test by Kim (Web team).

Screenshot 2024-03-25 at 2.11.30 PM.png (1×3 px, 378 KB)

Before/After:

Screenshot 2024-03-25 at 4.53.34 PM.png (534×776 px, 57 KB)

Screenshot 2024-03-25 at 4.52.53 PM.png (623×775 px, 66 KB)

Questions:

Did we intend to create extra space between links in a Field?
Are there other examples of extra spacing in Fields that we are not aware of and need to be addressed?

Acceptance Criteria

Remove the excess spacing (margin-top) from HTMLInfoField

Details

	Subject	Repo	Branch	Lines +/-
	CodexHTMLForm: Fix margins around links in login form	mediawiki/core	master	+3 -11
	CodexHTMLForm: Fix margins around links in login form	mediawiki/core	wmf/1.42.0-wmf.24	+3 -11

Customize query in gerrit

Related Objects

Mentioned Here: T358827: Adjacent Field components should have spacing between them

Event Timeline

lwatson created this task.Mar 25 2024, 8:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 25 2024, 8:52 PM

lwatson updated the task description. (Show Details)Mar 25 2024, 8:54 PM

lwatson updated the task description. (Show Details)Mar 25 2024, 9:16 PM

Change #1014135 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] CodexHTMLForm: Fix margins around links in login form

https://gerrit.wikimedia.org/r/1014135

gerritbot added a project: Patch-For-Review.Mar 25 2024, 11:45 PM

Catrope claimed this task.Mar 26 2024, 4:31 AM

Catrope edited projects, added Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)); removed Design-System-Team.

Catrope moved this task from Committed to Code Review on the Design-System-Team (DST-Sprint-19 (2024-03-18 to 2024-03-29)) board.

Change #1014135 merged by jenkins-bot:

[mediawiki/core@master] CodexHTMLForm: Fix margins around links in login form

https://gerrit.wikimedia.org/r/1014135

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.25; 2024-04-02).Mar 26 2024, 3:00 PM

Catrope added a project: Regression.Mar 26 2024, 4:10 PM

Change #1014456 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@wmf/1.42.0-wmf.24] CodexHTMLForm: Fix margins around links in login form

https://gerrit.wikimedia.org/r/1014456

Change #1014456 merged by jenkins-bot:

[mediawiki/core@wmf/1.42.0-wmf.24] CodexHTMLForm: Fix margins around links in login form

https://gerrit.wikimedia.org/r/1014456

Mentioned in SAL (#wikimedia-operations) [2024-03-26T20:21:11Z] <catrope@deploy1002> Started scap: Backport for [[gerrit:1014456|CodexHTMLForm: Fix margins around links in login form (T360945)]]

Mentioned in SAL (#wikimedia-operations) [2024-03-26T20:27:01Z] <catrope@deploy1002> catrope: Backport for [[gerrit:1014456|CodexHTMLForm: Fix margins around links in login form (T360945)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-03-26T20:43:21Z] <catrope@deploy1002> Finished scap: Backport for [[gerrit:1014456|CodexHTMLForm: Fix margins around links in login form (T360945)]] (duration: 22m 09s)