Maniphest T361408

CodexHTMLForm: fix spacing around buttons at the bottom of the form
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Catrope
	Mar 29 2024, 9:04 PM

Tags

Referenced Files

	F43796214: image.png
	Mar 29 2024, 9:04 PM

Subscribers

Description

Right now the buttons at the bottom of the form are wrapped in a <span class="mw-htmlform-submit-buttons"> tag. This span doesn't have any margins on it, and because the rest of the form fields have top margins, there's no spacing between the buttons and the form.

image.png (195×415 px, 19 KB)

Make this tag a div instead of a span (OOUIHTMLForm does this too)
Style it to have a top margin of 16px (@spacing-100), but only in CodexHTMLForm

Details

	Subject	Repo	Branch	Lines +/-
	htmlform: Introduce CodexHTMLForm stylesheet	mediawiki/core	master	+19 -0

Customize query in gerrit

Event Timeline

Catrope created this task.Mar 29 2024, 9:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 29 2024, 9:04 PM

Catrope moved this task from Inbox to Up Next on the Design-System-Team board.Mar 29 2024, 9:04 PM

CCiufo-WMF triaged this task as High priority.Mon, Apr 1, 1:53 PM

Catrope set the point value for this task to 1.Mon, Apr 1, 5:17 PM

Catrope moved this task from Up Next to DST-Sprint-20 (2024-04-01 to 2024-04-12) on the Design-System-Team board.Mon, Apr 1, 5:24 PM

Catrope edited projects, added Design-System-Team (DST-Sprint-20 (2024-04-01 to 2024-04-12)); removed Design-System-Team.

Change #1015615 had a related patch set uploaded (by Catrope; author: VolkerE):

[mediawiki/core@master] htmlform: Introduce CodexHTMLForm stylesheet

https://gerrit.wikimedia.org/r/1015615

gerritbot added a project: Patch-For-Review.Tue, Apr 2, 5:07 PM

Catrope assigned this task to Volker_E.Tue, Apr 2, 5:08 PM

Catrope moved this task from Committed to Code Review on the Design-System-Team (DST-Sprint-20 (2024-04-01 to 2024-04-12)) board.

Catrope closed this task as Resolved.Wed, Apr 3, 12:23 AM

Catrope moved this task from Code Review to Pending Release on the Design-System-Team (DST-Sprint-20 (2024-04-01 to 2024-04-12)) board.

Change #1015615 merged by jenkins-bot:

[mediawiki/core@master] htmlform: Introduce CodexHTMLForm stylesheet

https://gerrit.wikimedia.org/r/1015615

Volker_E removed a project: Patch-For-Review.Wed, Apr 3, 3:01 PM

Volker_E updated the task description. (Show Details)

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.26; 2024-04-09).Wed, Apr 3, 3:02 PM