Page MenuHomePhabricator

🦮 Add a title to the main logo graphic
Closed, ResolvedPublic1 Estimated Story Points

Description

Currently it is the first focusable element on the page yet the graphic has no text description.

Event Timeline

Tanuja_Doriya renamed this task from Add a title to the main logo graphic to 🦮 Add a title to the main logo graphic.Apr 8 2024, 2:36 PM
Tanuja_Doriya removed Tanuja_Doriya as the assignee of this task.
Tanuja_Doriya moved this task from Doing to Review on the WMDE-FUN-Sprint-2024-02-27 board.
Tanuja_Doriya subscribed.
kai.nissen set the point value for this task to 1.Apr 9 2024, 10:39 AM

this was changed to make the screenreader ignore the logo instead.
PR is merged and deployed at https://test-spenden-2.wikimedia.de/

@Tanuja_Doriya Maybe it's a Linux/Orca issue, but the logo element can still be reached using keyboard navigation.

Fix PR: https://github.com/wmde/fundraising-app-frontend/pull/385

@kai.nissen Thank you for spotting the issue. I have fixed it now. Please let me know if it still does not behave as expected.

@kai.nissen An update, I decided that it'd be better to leave it be tabbable and to add some hidden text to the element as that seems to be the standard practice.

Okay, the changes that I made were:

  1. Main logo can not be reached by keyboard navigation
  2. Screen reader will read a 'title' of the organization

Abban commented above that we want to keep the logo tabbable. @kai.nissen Could you please write the final requirements in the ticket? So that there is no confusion later.