Page MenuHomePhabricator

Resolve All Function Call Internals Ephemerally
Open, MediumPublic

Description

Description

The orchestrator sometimes calls resolveKey on objects that are not part of a return value, but part of the function call's machinery (e.g., resolveKey( [ 'Z7K1', 'Z8K2' ] )). It should instead call resolveEphemeral on these objects and, accordingly, use getNameEphemeral to access function call internals.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • less prolix return values (especially for certain classes of errors)

Completion checklist

Event Timeline

Ha, was about to file this based on the test changes I had to make for https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/152 – adding the equality functions for some types shouldn't change the returns.

Mcastro lowered the priority of this task from High to Medium.
Mcastro moved this task from To Triage to Backlog on the Abstract Wikipedia team board.