Page MenuHomePhabricator

Display contributions from temporary accounts on Special:Contributions/IP
Closed, ResolvedPublic

Assigned To
Authored By
Tchanders
Thu, Apr 4, 6:25 PM
Referenced Files
F45279715: image.png
Tue, Apr 9, 12:14 AM
F45279614: image.png
Tue, Apr 9, 12:14 AM
F45279559: image.png
Tue, Apr 9, 12:14 AM
F45279525: image.png
Tue, Apr 9, 12:14 AM
F45279990: image.png
Tue, Apr 9, 12:14 AM
F45240300: image.png
Mon, Apr 8, 5:25 PM

Description

Background

See parent task for full details: T358852

What needs doing

Add lines for contributions by temporary accounts on Special:Contributions for a single IP address (as opposed to a range, which will be done in a separate task). This is fairly straightforward to do, since Special:Contributions looks up the revisions by actor name. So we can just handle the ContribsPager__getQueryInfo from CheckUser, look up which temporary users have edited recently from that IP, and add their names into the query conditions.

This task doesn't include:

  • Showing temp account contributions on Special:Contributions/IP-range
  • Displaying temp account names in the recent changes lines
  • Special:DeletedContributions

Event Timeline

Change #1015098 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] WIP Show temp account edits on Special:Contributions for an IP address

https://gerrit.wikimedia.org/r/1015098

Dreamy_Jazz subscribed.

Suggested QA steps for local wiki or patch demo:

  1. Install CheckUser
  2. Enable temporary account autocreation
  3. Make an edit while logged out (which should also create a temporary account for you)
  4. Note down the username of this temporary account
  5. Log into an account with the checkuser user group
  6. Find the edit made by the temporary account and press Show IP
  7. Load Special:Contributions for the IP address that was displayed in step 6
  8. Verify that the edit by the temporary account performed in step 3 appears in the contributions list, including that the username of the temporary account that made the edit is shown. For example, it should look like the following:

image.png (64×920 px, 16 KB)

  1. Load Special:Contributions for the IP address that was displayed in step 6 while logged out and verify that the edit performed by the temporary account in step 3 is not shown.

Change #1015098 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Show temp account edits on Special:Contributions for an IP address

https://gerrit.wikimedia.org/r/1015098

I have verified the new code has been implemented and is functioning and displaying as expected... Thank You @Dreamy_Jazz!!!

image.png (589×1 px, 209 KB)

image.png (496×1 px, 70 KB)

image.png (470×1 px, 69 KB)

image.png (552×1 px, 68 KB)

image.png (446×1 px, 42 KB)