Page MenuHomePhabricator

Set GlobalBlocking account blocks config to false on REL1_42
Closed, ResolvedPublic

Description

The wgGlobalBlockingAllowGlobalAccountBlocks configuration value in the GlobalBlocking extension needs to be set to false in the REL1_42 branch, as the feature to globally block accounts is not yet stable. Setting the value to false will ensure that third-party wikis do not have a half-functioning experience unless they specifically set the configuration value to true.

The value is set to true in extension.json to allow easier local testing.

Event Timeline

FYI, the 1.42 branch point is in a matter of hours; do you want to get this done by then?

Ideally I wanted it to still be true for the master branch. Therefore, my understanding is that this can't be done until the REL1_42 branch exists.

Ideally I wanted it to still be true for the master branch.

Oh, sure, making the change in the REL1_42 branch once it exists should work fine.

Change #1017957 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/GlobalBlocking@master] Set GlobalBlockingAllowGlobalAccountBlocks to false for the REL1_42 release branch

https://gerrit.wikimedia.org/r/1017957

Change #1018218 had a related patch set uploaded (by Dreamy Jazz; author: Jforrester):

[mediawiki/extensions/GlobalBlocking@REL1_42] Set GlobalBlockingAllowGlobalAccountBlocks to false for the REL1_42 release branch

https://gerrit.wikimedia.org/r/1018218

Change #1017957 abandoned by Dreamy Jazz:

[mediawiki/extensions/GlobalBlocking@master] Set GlobalBlockingAllowGlobalAccountBlocks to false for the REL1_42 release branch

Reason:

https://gerrit.wikimedia.org/r/1017957

Change #1018260 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Pin wgGlobalBlockingAllowGlobalAccountBlocks in tests that need it

https://gerrit.wikimedia.org/r/1018260

Change #1018218 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@REL1_42] Set GlobalBlockingAllowGlobalAccountBlocks to false for the REL1_42 release branch

https://gerrit.wikimedia.org/r/1018218

Change #1018260 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Pin wgGlobalBlockingAllowGlobalAccountBlocks in tests that need it

https://gerrit.wikimedia.org/r/1018260