Page MenuHomePhabricator

$wgUseCategoryBrowser = true create trailing '>' and add an unwanted category
Closed, DeclinedPublic

Description

Author: sylvain_machefert

Description:
In my settings, I set
$wgUseCategoryBrowser = true;

I get a wonderful Category Browser on my pages :)

Just a few things.

My page has [[Catégorie:Maria Tanase]] (in French).
My wiki structure could be drawn like this

root

+-- TODO
+-- Pays

+-- Grèce
+-- Roumanie
+-- Maria Tanase
+--...
+--...

+-- Danse
+-- ...

Displaying an article in "Maria Tanase" shows :

Catégories de la page: Maria Tanase

TODO >
Pays > Roumanie > Maria Tanase >

  1. There is a trailing '>' (greater than) at the end of the

line

  1. There is an unespected "TODO" line. My article is *not* in

TODO. If the CategoryBrowser wanted to show all categories, a
lot of them are missing (Grèce, Danse...).

[21:18] <iubito> for the $wgUseCategoryBrowser, just one thing,
it adds a trailing '>' that is no useful... Example :
[21:18] <iubito> Catégories de la page: Maria Tanase
[21:18] <iubito> TODO >
[21:18] <iubito> Pays > Roumanie > Maria Tanase >
[21:18] <Hashar> iubito> yup that s a bug :o)


Version: 1.4.x
Severity: normal
URL: http://tousauxbalkans.free.fr/Agurida

Details

Reference
bz1622
TitleReferenceAuthorSource BranchDest Branch
Draft: [WIP]: Implement "Project" sectionrepos/commtech/wishlist-intake!8samtarT362275main
[PHP] Update MetricsClient#submitInteraction()repos/data-engineering/metrics-platform!41phuedxwork/phuedx/T362214main
builds-api: bump to 0.0.143-20240415191619-ae83a3bcrepos/cloud/toolforge/toolforge-deploy!260project_1317_bot_df3177307bed93c3f34e421e26c86e38bump_builds-apimain
[envvars-api] update oapi-codegenrepos/cloud/toolforge/envvars-api!28raymond-ndibeupdate_oapi_codegenmain
Draft: [oapi-spec] add oapi-server to gatewayrepos/cloud/toolforge/api-gateway!17sstefanovaslavina/add-oapi-servermain
Rename CategorySection to TaskSectionrepos/commtech/wishlist-intake!4musikanimalT362274main
[builds-api] update oapi-codegenrepos/cloud/toolforge/builds-api!86raymond-ndibeupdate_oapi_codegenmain
Implement 'Category' section and rework entrypointrepos/commtech/wishlist-intake!3musikanimalcategory-sectionmain
db: Call wikilambda_fetch with uselang=content to aide cachingrepos/abstract-wiki/wikifunctions/function-orchestrator!157jforresterT362271main
d/changelog: bump to 16.0.7repos/cloud/toolforge/jobs-cli!27dcarobump_to_16.0.7main
cli: use the boolean value for filelogrepos/cloud/toolforge/jobs-cli!26dcarofix_filelog_on_dumpmain
Show related patches Customize query in GitLab

Revisions and Commits

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:16 PM
bzimport set Reference to bz1622.

sylvain_machefert wrote:

I still have the unwanted "TODO" category. Why ?
Is this because Maria Tanase has TODO ?
Agurida is an article in Maria Tanase category, but this article has not TODO, as said on the first line ''Catégories de la page...''

All articles in Maria Tanase category behave the same.

http://tousauxbalkans.free.fr/index.php?title=Agurida

Catégories de la page: Maria Tanase


TODO
Pays > Roumanie > Maria Tanase

sylvain_machefert wrote:

It's what I guessed :
if I remove [[Catégorie:TODO]] from Maria Tanase, Agurida and other articles in Maria Tanase category don't have the TODO.

sylvain_machefert wrote:

Ignore comments #2 and #3, it seems to be partly fixed in 1.4.2

but there is still a problem.
http://tousauxbalkans.free.fr/index.php?title=Agurida
Agurida is in category Maria Tanase

Maria Tanase is in category TODO,
and also in category Roumanie which is in category Pays

In the page I gave the URL, there is
Catégories de la page: Maria Tanase

Pays > Roumanie
TODO > Maria Tanase

That's better than what we had before, but there is a missing "Maria Tanase" in the path Pays > Roumanie > Maria Tanase
The 2nd path (TODO > Maria Tanase) is OK.

Fixed in head. Thanks for the report.

sylvain_machefert wrote:

Hi Brion

I don't know, I didn't upgrade to 1.5 due to a lot of little changes in my 1.4.4 code I'd lost in an upgrade...

I should try on a demo mediawiki 1.5 which has $wgUseCategoryBrowser = true

Category A
Category B is [[Category:A]]
Category C is [[Category:B]]
so we have one path A > B > C
Category B is also [[Category:D]]
so we have another path D > B > C
in 1.4.4, if Article is [[Category:C]], the category browser shows one complete path, and the other is incomplete (A > B > C and D).
If in 1.5 we have :
A > B > C and D > B > C, this bug is fixed.
If not, that's not huge, do what you want with this bug.

Is there a demo wiki using 1.5 and category browser ?

Not sure when this was fixed, but it was at some point between 1.5 and now. WORKSFORME on trunk.

Diffusion changed the task status from Declined to Resolved by committing Unknown Object (Diffusion Commit).Mar 4 2015, 8:22 AM
Diffusion added a commit: Unknown Object (Diffusion Commit).
demon changed the task status from Resolved to Declined.Mar 4 2015, 8:42 AM