Page MenuHomePhabricator

Phabricator links processed twice
Open, Needs TriagePublicBUG REPORT


Steps to replicate the issue (include links if applicable):

  • Run the theme locally with MediaWiki core and enable the ../wmf-theme/plugins/betterlinks plugin
  • Navigate to the page

What happens?:

The Phabricator link, which in the source appears like <>, appears like T121646"> T121646}..

This happens because the betterlinks plugin processes links like this twice: once as a link and once as a Phabricator task number. There are a few instances of full Phabricator links in the docs. We could resolve this by changing all Phabricator links to just the task number, or we could remove the logic from the plugin that automatically links task numbers. I'm inclined to do the latter option since links with just the task number aren't very useful when viewed from code comments and, even if we document that all Phabricator links should be just the task number, any mistakes won't be handled gracefully.

What should have happened instead?:

The link should appear either as or T121646

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Latest theme master

Other information (browser name/version, screenshots, etc.):


Related Objects