Page MenuHomePhabricator

ZObjectStringRenderer: Handle renderer error when view mode
Closed, ResolvedPublicBUG REPORT

Description

Description

Steps to reproduce:

  1. Go to edit page: https://wikifunctions.beta.wmflabs.org/wiki/Z11645?action=edit
    • The renderer function fails
    • The failure is shown as an error state of the input field
    • It can be expanded and inspected
    • When collapsed, renderer runs again
      Screenshot from 2024-04-15 12-55-43.png (169×757 px, 9 KB)
  2. Go to view page: https://wikifunctions.beta.wmflabs.org/view/en/Z11645
    • The renderer function fails
    • The failure is shown below an invisible text
    • When expanded, the error disappears
    • When collapsed, the renderer function doesn't run again, so the state is not visible
      Screenshot from 2024-04-15 12-55-53.png (159×766 px, 9 KB)
      Screenshot from 2024-04-15 13-00-56.png (149×769 px, 3 KB)

Expected behavior (Acceptance criteria):

  • When a renderer error occurs on view, it should be properly communicated
  • The error should not disappear

Devices and Design (URLs or screenshots, if applicable):

  • Desktop: ...
  • Small screens/mobile: ...

Completion checklist

Event Timeline

Change #1036584 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Fixit: Show display placeholder in view page when renderer function returns an error

https://gerrit.wikimedia.org/r/1036584

Change #1036584 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fixit: Show display placeholder in view page when renderer function returns an error

https://gerrit.wikimedia.org/r/1036584