Page MenuHomePhabricator
Create Task
Maniphest T362848

Refactor message group loaders
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

I suggest to refactor message group loaders to simplify them by separating the cache handling into separate class. This will also allow better dependency injection to the loaders.

Details

SubjectRepoBranchLines +/-
Cleanups after conversion to message group factoriesmediawiki/extensions/Translatemaster+19 -294
Add HookDefinedMessageGroupFactorymediawiki/extensions/Translatemaster+100 -75
Convert FileBasedMessageGroupLoader to factorymediawiki/extensions/Translatemaster+178 -288
AggregateMessageGroupLoader: convert to a factorymediawiki/extensions/Translatemaster+152 -222
Rewrite MessageBundleMessageGroupLoadermediawiki/extensions/Translatemaster+135 -138
Rewrite TranslatablePageMessageGroupStoremediawiki/extensions/Translatemaster+230 -287
Customize query in gerrit

Event Timeline

Nikerabbit created this task.Apr 18 2024, 7:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 18 2024, 7:47 AM
Nikerabbit added projects: Language-Team (Language-2024-April-June), Unplanned-Sprint-Work, Localization Infrastructure FY2023-24.Apr 18 2024, 7:48 AM
Nikerabbit set the point value for this task to 4.
Nikerabbit moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2024-April-June) board.
Nikerabbit moved this task from Backlog to Support (LM) on the Localization Infrastructure FY2023-24 board.
Nikerabbit moved this task from Backlog to group management on the MediaWiki-extensions-Translate board.
gerritbot added a comment.Apr 18 2024, 7:58 AM

Change #1016352 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/Translate@master] Rewrite TranslatablePageMessageGroupStore

https://gerrit.wikimedia.org/r/1016352

gerritbot added a project: Patch-For-Review.Apr 18 2024, 7:58 AM
abi_ triaged this task as Medium priority.Apr 24 2024, 10:30 AM
gerritbot added a comment.May 5 2024, 9:05 AM

Change #1027537 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/Translate@master] Rewrite MessageBundleMessageGroupLoader

https://gerrit.wikimedia.org/r/1027537

gerritbot added a comment.May 6 2024, 7:59 AM

Change #1016352 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Rewrite TranslatablePageMessageGroupStore

https://gerrit.wikimedia.org/r/1016352

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).May 6 2024, 8:00 AM
gerritbot added a comment.May 6 2024, 10:38 AM

Change #1027537 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Rewrite MessageBundleMessageGroupLoader

https://gerrit.wikimedia.org/r/1027537

Maintenance_bot removed a project: Patch-For-Review.May 6 2024, 11:30 AM
abi_ subscribed.May 6 2024, 12:59 PM

The refactored versions of TranslatablePage and MessageBundle loaders have been deployed on translatewiki.net

gerritbot added a comment.May 21 2024, 12:59 PM

Change #1034490 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/Translate@master] AggregateMessageGroupLoader: convert to a factory

https://gerrit.wikimedia.org/r/1034490

gerritbot added a project: Patch-For-Review.May 21 2024, 12:59 PM
gerritbot added a comment.May 22 2024, 10:03 AM

Change #1034490 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/Translate@master] AggregateMessageGroupLoader: convert to a factory

https://gerrit.wikimedia.org/r/1034490

gerritbot added a comment.May 22 2024, 11:16 AM

Change #1034490 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] AggregateMessageGroupLoader: convert to a factory

https://gerrit.wikimedia.org/r/1034490

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.7; 2024-05-28); removed MW-1.43-notes (1.43.0-wmf.4; 2024-05-07).May 22 2024, 12:01 PM
gerritbot added a comment.May 27 2024, 11:44 AM

Change #1036243 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/Translate@master] Convert FileBasedMessageGroupLoader to factory

https://gerrit.wikimedia.org/r/1036243

gerritbot added a comment.May 27 2024, 11:44 AM

Change #1036244 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/Translate@master] Add HookDefinedMessageGroupFactory

https://gerrit.wikimedia.org/r/1036244

gerritbot added a comment.Jun 5 2024, 8:22 AM

Change #1036243 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Convert FileBasedMessageGroupLoader to factory

https://gerrit.wikimedia.org/r/1036243

gerritbot added a comment.Jun 5 2024, 8:30 AM

Change #1036244 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Add HookDefinedMessageGroupFactory

https://gerrit.wikimedia.org/r/1036244

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.9; 2024-06-11); removed MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).Jun 5 2024, 9:00 AM
gerritbot added a comment.Jun 6 2024, 7:23 AM

Change #1039550 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/Translate@master] Cleanups after conversion to message group factories

https://gerrit.wikimedia.org/r/1039550

Nikerabbit moved this task from In Progress to In Review on the Language-Team (Language-2024-April-June) board.Jun 6 2024, 9:43 AM
gerritbot added a comment.Jun 11 2024, 6:16 AM

Change #1039550 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Cleanups after conversion to message group factories

https://gerrit.wikimedia.org/r/1039550

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.10; 2024-06-18); removed MW-1.43-notes (1.43.0-wmf.9; 2024-06-11).Jun 11 2024, 7:00 AM
Nikerabbit closed this task as Resolved.Jun 11 2024, 7:38 AM
Nikerabbit removed a project: Patch-For-Review.
Nikerabbit moved this task from In Review to Done on the Language-Team (Language-2024-April-June) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits