Page MenuHomePhabricator

Re-write ext.wikilambda.edit/mixins/schemata.js to not create globals
Open, MediumPublic

Description

Per https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Exporting we shouldn't ever be creating globals as it's unsafe.

Event Timeline

Jdforrester-WMF moved this task from To Triage to Backlog on the Abstract Wikipedia team board.

Change #1021536 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] [WIP] Start re-writing schemata.js to not export globals

https://gerrit.wikimedia.org/r/1021536

Change #1021536 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] schemata.js: Start moving global functions into their uses

https://gerrit.wikimedia.org/r/1021536

@Jdforrester-WMF can we resolve this ticket? since its released

No, my patch only did 1% of the work here. This is all hidden by the allowedGlobals field in jsdoc.json which should be empty.