Per https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Exporting we shouldn't ever be creating globals as it's unsafe.
Description
Description
Details
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
schemata.js: Start moving global functions into their uses | mediawiki/extensions/WikiLambda | master | +67 -63 |
Event Timeline
Comment Actions
Change #1021536 had a related patch set uploaded (by Jforrester; author: Jforrester):
[mediawiki/extensions/WikiLambda@master] [WIP] Start re-writing schemata.js to not export globals
Comment Actions
Change #1021536 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] schemata.js: Start moving global functions into their uses
Comment Actions
No, my patch only did 1% of the work here. This is all hidden by the allowedGlobals field in jsdoc.json which should be empty.