Page MenuHomePhabricator

Enable e-mailing password based on e-mail address on Wikimedia wikis
Closed, ResolvedPublic

Description

Please enable the new feature to email passwords based on email on the WMF wikis.

If I understand bug 13015 and the code correctly, this requires running patch-user_email_index.sql and setting $wgPasswordResetRoutes['username'] to true.

I think this will help keep sporadic editors and readers. I know I've sometimes forgotten usernames (on non-WMF sites). Right now, we tell such users we can't help them (http://en.wikipedia.org/wiki/Wikipedia:Contact_us/login_problems).


Version: unspecified
Severity: enhancement

Details

Reference
bz34386

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:13 AM
bzimport set Reference to bz34386.

You have to set

$wgPasswordResetRoutes['email'] = true;

to enable this feature, after adding the index.

It is possible to get the index? Thanks.

It is possible to get the index? Thanks.

Asher, I guess this is doable (though, isn't going to be quick!). Would you be able to arrange to get this sorted?

CREATE INDEX /*i*/user_email ON /*_*/user (user_email(50));

Do you want an RT ticket creating?

Also, I wonder if we need to put this index onto the CentralAuth globaluser.gu_email, and as such, add the functionality to CA and allow it to be used if needed

(In reply to comment #5)

Also, I wonder if we need to put this index onto the CentralAuth
globaluser.gu_email, and as such, add the functionality to CA and allow it to
be used if needed

A global account has always the same email in all wikis, so this should not be a problem, when the email stored in the local user table is the same than the global email. If in the local user table another email is stored, this feature will not work properly (I am not sure, if CentralAuth updates (all) emails on the local wikis or is only changing it with a hook, when loading a user object)

(In reply to comment #4)

Do you want an RT ticket creating?

Has somebody create a RT ticket?

One week is over, has somebody created a RT ticket?

Next week is over, has somebody created a RT ticket?

Next week is over, exist a RT ticket?

Next week is over, exist a RT ticket?

Asher, has you time to do this? Thanks.

Next week is over.

It is possible to get a comment, if this can be done and maybe when this is done? Thanks.

Hi Umherirrender. I'll have an answer for you shortly.

How does this handle multiple accounts with the same email?

(In reply to comment #14)

How does this handle multiple accounts with the same email?

I guess it'd just use the first it finds.. I'm not sure what other sites do.

afeldman wrote:

I should have the user.user_email index applied to all projects within 24 hours of now.

(In reply to comment #5)

Also, I wonder if we need to put this index onto the CentralAuth
globaluser.gu_email, and as such, add the functionality to CA and allow it to
be used if needed

Turns out there already was one anyway in the CA schema file:

key (gu_email),

And it's already on the cluster too

(In reply to comment #18)

I should have the user.user_email index applied to all projects within 24 hours
of now.

I just want to say that you're wonderful and thank you.

afeldman wrote:

Migrations completed for all projects. Thanks to Reedy for emailing me directly, I completely missed this ticket originally :)

Thanks for applying the index to all projects.

Next step is to change the config to enable the new feature.
The following line is needed:

$wgPasswordResetRoutes['email'] = true;

Thanks.

(In reply to comment #22)

Thanks for applying the index to all projects.

Next step is to change the config to enable the new feature.
The following line is needed:

$wgPasswordResetRoutes['email'] = true;

Thanks.

Do you have a Git/Gerrit account? I believe you can submit a changeset for this nowadays and then ask for it to be merged.

(In reply to comment #23)

(In reply to comment #22)

Thanks for applying the index to all projects.

Next step is to change the config to enable the new feature.
The following line is needed:

$wgPasswordResetRoutes['email'] = true;

Thanks.

Do you have a Git/Gerrit account? I believe you can submit a changeset for this
nowadays and then ask for it to be merged.

I have a account, but not a clone of the config repo.

Now done with gerrit 21326

Bug assigned to code submitter.

  • Bug 36656 has been marked as a duplicate of this bug. ***

config change is successfully merged