Page MenuHomePhabricator

img_auth.php bugfix
Closed, ResolvedPublic

Description

Author: avarab

Description:
This patch fixes a small bug in img_auth.php and cleans up the code by avoiding
a needless variable which makes it harder to understand.


Version: 1.4.x
Severity: normal
Platform: Other

Details

Reference
bz1642

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:13 PM
bzimport set Reference to bz1642.
bzimport added a subscriber: Unknown Object (MLST).

avarab wrote:

the patch against img_auth.php

attachment img_auth.php.patch ignored as obsolete

The $endl bit is there because a file checked out on a Windows server will have CRLF line feeds instead of LF.

avarab wrote:

Updated the patch

Despite my patch not accounting for CRLF line feeds the bug as a whole is not
INVALID, only half of it, the x-conference/x-cooltalk ice"; line still needs to
be changed to x-conference/x-cooltalk ice.

Attached:

avarab wrote:

A testcase which shows that the "; causes problems

Attached:

avarab wrote:

Comment on attachment 336
the patch against img_auth.php

marked the first one obsolete