Page MenuHomePhabricator
Create Task
Maniphest T36442

Reviewer is still able to accept a message after changing it
Closed, DeclinedPublic
Actions

Description

As in, if he doesn't reload Special:Translate after changing a message, the "Accept" button is still there, can be pressed, it says that the translation has been accepted and the action is logged.
This has no real consequences as the extension will correctly report the translation as unreviewed.

Might be related to the fact that the review is logged as action on the page rather than on a specific revision as mentioned on bug 34153?

Example:
https://translatewiki.net/w/i.php?title=Wikia%3ADump-database-info%2Fit&action=historysubmit&diff=3697310&oldid=3696533
https://translatewiki.net/w/i.php?title=Special:Log/Nemo_bis&dir=prev&offset=20120216120848&limit=1&type=&user=Nemo+bis

Version: unspecified
Severity: trivial

Details

Reference
bz34442

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 12:17 AM
• bzimport added a project: MediaWiki-extensions-Translate.
• bzimport set Reference to bz34442.
Nemo_bis created this task.Feb 16 2012, 12:23 PM
siebrand added a comment.Feb 16 2012, 12:48 PM

That's not a problem. You're accepting the previous version, and the current version (by "you") remains unreviewed.

Nemo_bis added a comment.Feb 16 2012, 1:20 PM

I see. But usually I'm not allowed to review the previous version either, although that's because there's only one accept button.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL