Page MenuHomePhabricator

"back" action doesn't work in step specs declared under gt.defineTour
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Get a tour, such as twa1.
  • Use gt.definetour and give a button the 'back' action.
  • Trigger the tour and try to click on the "back" button.

What happens?:

Nothing, and a console error is logged.

What should have happened instead?:

We correctly go back to the last step.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Wikipedia

Related Objects

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1031109 had a related patch set uploaded (by Pppery; author: Pppery):

[mediawiki/extensions/GuidedTour@master] gt.DefineTour: Fix back button, return builder

https://gerrit.wikimedia.org/r/1031109

Huh, that was easier than I thought it would be. Thanks!

Change #1031109 merged by jenkins-bot:

[mediawiki/extensions/GuidedTour@master] gt.DefineTour: Fix back button, return builder

https://gerrit.wikimedia.org/r/1031109

Pppery removed a project: Patch-For-Review.