Page MenuHomePhabricator

Upstream rPHABf2fd14dc1edeb41aa2874336548cfaa7fa0e87a0 (maniphest.gettasktransactions API)
Closed, ResolvedPublic

Description

rPHABf2fd14dc1edeb41aa2874336548cfaa7fa0e87a0 introduced additional metadata to the maniphest.gettasktransactions Conduit call
and I don't know why because no associated ticket and no provided context in the commit message, thus no idea what is or was the use case.
parsed by the wikibugs bot to create IRC change notifications.

Difference in output are two additional fields:

  • "title": "aklapper unsubscribed." / "title": "aklapper created this task.", / "title": "aklapper added a comment."
  • "meta": [] / "meta": { "remarkup.control": [], "core.groupID": "4mxmptmwn5ndj473hpnzwhsrq2mcu3zz" } / "meta": { "edge:type": 51, "core.groupID": "loybeofa7yobhq2ixzsbc3lba4pd6czz" }

Details

Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Revert "Add metadata to the gettasktransactions conduit method response"repos/phabricator/phabricator!61aklapperT364728rmConduitMetadatawmf/stable
Customize query in GitLab

Event Timeline

Aklapper triaged this task as Low priority.

aklapper merged https://gitlab.wikimedia.org/repos/phabricator/phabricator/-/merge_requests/61

Revert "Add metadata to the gettasktransactions conduit method response"

Deployed on 2024-06-25; setting status to resolved.

Seems that wikibugs IRC client relies on 'meta' => $transaction->getMetadata(),. From #wikimedia-releng:

<taavi> seems like it's crashing with
<taavi> 2024-06-25T15:43:09+00:00 [phorge-7ffcbf8d99-8z648] File "/workspace/src/wikibugs2/phorge.py", line 235, in get_transaction_info
<taavi> 2024-06-25T15:43:09+00:00 [phorge-7ffcbf8d99-8z648] if "core.create" in trans["meta"]:
<taavi> 2024-06-25T15:43:09+00:00 [phorge-7ffcbf8d99-8z648] ~~~~~^^^^^^^^
<taavi> 2024-06-25T15:43:09+00:00 [phorge-7ffcbf8d99-8z648] KeyError: 'meta'

Mentioned in SAL (#wikimedia-operations) [2024-06-25T16:08:28Z] <brennen@deploy1002> Started deploy [phabricator/deployment@72ad841]: deploy phab2002 for T368392 - followup T364728

Mentioned in SAL (#wikimedia-operations) [2024-06-25T16:09:01Z] <brennen@deploy1002> Finished deploy [phabricator/deployment@72ad841]: deploy phab2002 for T368392 - followup T364728 (duration: 00m 33s)

Mentioned in SAL (#wikimedia-operations) [2024-06-25T16:10:16Z] <brennen@deploy1002> Started deploy [phabricator/deployment@72ad841]: deploy phab1004 for T368392 - followup T364728

Mentioned in SAL (#wikimedia-operations) [2024-06-25T16:10:55Z] <brennen@deploy1002> Finished deploy [phabricator/deployment@72ad841]: deploy phab1004 for T368392 - followup T364728 (duration: 00m 39s)

Aklapper renamed this task from Revert or upstream rPHABf2fd14dc1edeb41aa2874336548cfaa7fa0e87a0 (maniphest.gettasktransactions API) to Upstream rPHABf2fd14dc1edeb41aa2874336548cfaa7fa0e87a0 (maniphest.gettasktransactions API).Jun 27 2024, 9:36 AM

This issue should now be fixed on phabricator.wikimedia.org after today's software deployment in T404134.