Page MenuHomePhabricator

TwoColConflict\Tests\TwoColConflictHooksTest::testOnEditPageShowEditFormFields: TypeError: Argument 1 passed to Skin::normalizeKey() must be of the type string, null given
Closed, ResolvedPublic

Description

Seen in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TwoColConflict/+/1030495

22:39:39 1) TwoColConflict\Tests\TwoColConflictHooksTest::testOnEditPageShowEditFormFields
22:39:39 TypeError: Argument 1 passed to Skin::normalizeKey() must be of the type string, null given, called in /workspace/src/includes/context/RequestContext.php on line 564
22:39:39 
22:39:39 /workspace/src/includes/skins/Skin.php:222
22:39:39 /workspace/src/includes/context/RequestContext.php:564
22:39:39 /workspace/src/includes/context/RequestContext.php:536
22:39:39 /workspace/src/includes/context/RequestContext.php:592
22:39:39 /workspace/src/includes/OutputTransform/Stages/HandleSectionLinks.php:207
22:39:39 /workspace/src/includes/OutputTransform/Stages/HandleSectionLinks.php:58
22:39:39 /workspace/src/includes/OutputTransform/Stages/HandleSectionLinks.php:45
22:39:39 /workspace/src/includes/OutputTransform/ContentTextTransformStage.php:17
22:39:39 /workspace/src/includes/OutputTransform/OutputTransformPipeline.php:72
22:39:39 /workspace/src/includes/parser/ParserOutput.php:473
22:39:39 /workspace/src/includes/Message/Message.php:1510
22:39:39 /workspace/src/includes/Message/Message.php:1068
22:39:39 /workspace/src/includes/Message/Message.php:1108
22:39:39 /workspace/src/extensions/TwoColConflict/includes/Html/CoreUiHintHtml.php:28
22:39:39 /workspace/src/extensions/TwoColConflict/includes/Hooks/TwoColConflictHooks.php:141
22:39:39 /workspace/src/extensions/TwoColConflict/tests/phpunit/TwoColConflictHooksTest.php:304
22:39:39 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106

Event Timeline

Change #1031388 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TwoColConflict@master] Fix TwoColConflictHooksTest messing up UserOptionsLookup

https://gerrit.wikimedia.org/r/1031388

Change #1031388 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] Fix TwoColConflictHooksTest messing up UserOptionsLookup

https://gerrit.wikimedia.org/r/1031388