Page MenuHomePhabricator

Closing the Special:NewPagesFeed "Set filters" menu by clicking the top left button should also update the feed
Closed, ResolvedPublicFeature

Description

Feature summary (what you would like to be able to do and where):
Closing the Special:NewPagesFeed "Set filters" menu by clicking the top left button should also update the feed. Currently closes the dialog, and saves the <input> values, but does not update the feed.

image.png (804×930 px, 91 KB)

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):

Benefits (why should this be implemented?):
Doesn't seem like a great idea to store one state in a closed form, and another in the Special:NewPagesFeed. These may get out of sync without the end user realizing it. I think the end user will always intend closing the form to mean that they want to apply their changes.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1056634 had a related patch set uploaded (by Yash9265; author: Yash9265):

[mediawiki/extensions/PageTriage@master] Fix filter update issue in Special:NewPagesFeed menu

https://gerrit.wikimedia.org/r/1056634

No need to ping people in Phab to review your patches. ReviewerBot adds us to your patches in Gerrit, which generates an email.

We are volunteers so patches are not urgent. We will get to them when we can.

Change #1056634 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Fix filter update issue in Special:NewPagesFeed menu

https://gerrit.wikimedia.org/r/1056634