"PHP Notice: Undefined index: width", "…height" in ThumbnailImage.php while running PHPUnit tests
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	May 14 2024, 4:19 PM

Description

Spotted while reviewing an unrelated test failure: https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-sqlite-php74/719/console

16:13:54 INFO:quibble.commands:composer run --timeout=0 phpunit:entrypoint -- --group Database --exclude-group Broken,ParserFuzz,Stub,Standalone
16:13:55 > phpunit '--group' 'Database' '--exclude-group' 'Broken,ParserFuzz,Stub,Standalone'
16:13:55 Using PHP 7.4.33
16:13:55 Running with MediaWiki settings because there might be integration tests
16:13:56 PHP Notice:  Undefined index: width in /workspace/src/includes/media/ThumbnailImage.php on line 79
16:13:56 PHP Notice:  Undefined index: height in /workspace/src/includes/media/ThumbnailImage.php on line 80
16:13:59 PHPUnit 9.6.19 by Sebastian Bergmann and contributors.

Details

	Subject	Repo	Branch	Lines +/-
	ThumbnailEntryPointTest: Fix PHP notice in data provider	mediawiki/core	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned Here: T214552: Jenkins build for MediaWiki should fail when "PHP Warning" is emitted

Event Timeline

matmarex created this task.May 14 2024, 4:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 14 2024, 4:19 PM

I'm guessing from the peculiar output that the notice is emitted by some test provider.

Change #1031510 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] ThumbnailEntryPointTest: Fix PHP notice in data provider

https://gerrit.wikimedia.org/r/1031510

gerritbot added a project: Patch-For-Review.May 14 2024, 4:30 PM

matmarex claimed this task.May 14 2024, 4:33 PM

Change #1031510 merged by jenkins-bot:

[mediawiki/core@master] ThumbnailEntryPointTest: Fix PHP notice in data provider

https://gerrit.wikimedia.org/r/1031510

Maintenance_bot removed a project: Patch-For-Review.May 14 2024, 6:30 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).May 14 2024, 7:00 PM

matmarex closed this task as Resolved.May 14 2024, 7:01 PM

There is T214552: Jenkins build for MediaWiki should fail when "PHP Warning" is emitted to detect this situation in CI directly

"PHP Notice: Undefined index: width", "…height" in ThumbnailImage.php while running PHPUnit testsClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

"PHP Notice: Undefined index: width", "…height" in ThumbnailImage.php while running PHPUnit tests
Closed, ResolvedPublic
Actions