Page MenuHomePhabricator
Create Task
Maniphest T365047

eslint: remove redundant ruleset wikimedia/jsdoc
Closed, ResolvedPublic
Actions

Description

According to my testing, if the linter eslint-config-wikimedia is installed in a repo, the following rulesets already include wikimedia/jsdoc (meaning wikimedia/jsdoc doesn't need to be declared separately):

  • wikimedia/client-es5
  • wikimedia/client-es6
  • wikimedia/client (alias for wikimedia/client-es6)
  • wikimedia/server

And the following rulesets do not (meaning wikimedia/jsdoc should be declared separately):

  • wikimedia/jquery
  • wikimedia/mediawiki
  • wikimedia/mocha

It should be safe to delete the ruleset "wikimedia/jsdoc" from the first bulleted list, since those rulesets already include it.

This will be a tracking task to link in my gerrit patches to, to help explain what I'm doing.

The following patch in core was +2'd, and has some insightful comments: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1031812

Details

Show related patches Customize query in gerrit
TitleReferenceAuthorSource BranchDest Branch
eslint: remove redundant ruleset wikimedia/jsdocrepos/abstract-wiki/wikifunctions/wikilambda-cli!39novemlinguaeeslint-remove-redundantmain
eslint: remove redundant ruleset wikimedia/jsdocrepos/mediawiki/services/ipoid!239novemlinguaeeslint-remove-redundantmain
Customize query in GitLab

Related Objects

Event Timeline

Novem_Linguae created this task.May 15 2024, 5:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 15 2024, 5:30 PM
gerritbot added a comment.May 15 2024, 5:31 PM

Change #1031815 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/Echo@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031815

gerritbot added a project: Patch-For-Review.May 15 2024, 5:31 PM
gerritbot added a comment.May 15 2024, 5:34 PM

Change #1031923 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/Flow@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031923

CodeReviewBot added a comment.May 15 2024, 5:57 PM

novemlinguae opened https://gitlab.wikimedia.org/repos/mediawiki/services/ipoid/-/merge_requests/239

eslint: remove redundant ruleset wikimedia/jsdoc

gerritbot added a comment.May 15 2024, 6:03 PM

Change #1031925 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/Citoid@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031925

gerritbot added a comment.May 15 2024, 6:05 PM

Change #1031986 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/Graph@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031986

gerritbot added a comment.May 15 2024, 6:07 PM

Change #1031987 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/Kartographer@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031987

gerritbot added a comment.May 15 2024, 6:08 PM

Change #1031988 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031988

gerritbot added a comment.May 15 2024, 6:08 PM

Change #1031989 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/Thanks@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031989

gerritbot added a comment.May 15 2024, 6:10 PM

Change #1031990 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/extensions/VisualEditor@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031990

gerritbot added a comment.May 15 2024, 6:13 PM

Change #1031992 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/services/example-node-api@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031992

gerritbot added a comment.May 15 2024, 6:14 PM

Change #1031993 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/services/kartotherian@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031993

gerritbot added a comment.May 15 2024, 6:15 PM

Change #1031994 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/services/parsoid@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031994

gerritbot added a comment.May 15 2024, 6:17 PM

Change #1031995 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/services/service-scaffold-node@main] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031995

gerritbot added a comment.May 15 2024, 6:18 PM

Change #1031996 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/services/servicelib-node@main] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031996

gerritbot added a comment.May 15 2024, 6:19 PM

Change #1031997 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/services/wikifeeds@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031997

CodeReviewBot added a comment.May 15 2024, 6:22 PM

novemlinguae opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/39

eslint: remove redundant ruleset wikimedia/jsdoc

gerritbot added a comment.May 15 2024, 7:36 PM

Change #1031992 merged by jenkins-bot:

[mediawiki/services/example-node-api@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031992

Novem_Linguae mentioned this in rMSENb4a8492a3602: eslint: remove redundant ruleset wikimedia/jsdoc.May 15 2024, 7:36 PM
gerritbot added a comment.May 15 2024, 7:38 PM

Change #1031997 merged by jenkins-bot:

[mediawiki/services/wikifeeds@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031997

gerritbot added a comment.May 15 2024, 7:39 PM

Change #1031996 merged by jenkins-bot:

[mediawiki/services/servicelib-node@main] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031996

CodeReviewBot added a comment.May 15 2024, 7:40 PM

jforrester merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/wikilambda-cli/-/merge_requests/39

eslint: remove redundant ruleset wikimedia/jsdoc

gerritbot added a comment.May 15 2024, 7:42 PM

Change #1031993 merged by jenkins-bot:

[mediawiki/services/kartotherian@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031993

Novem_Linguae mentioned this in rMSKA2c03f0fe3170: eslint: remove redundant ruleset wikimedia/jsdoc.May 15 2024, 7:42 PM
gerritbot added a comment.May 15 2024, 7:44 PM

Change #1031923 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031923

gerritbot added a comment.May 15 2024, 7:59 PM

Change #1031815 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031815

gerritbot added a comment.May 15 2024, 7:59 PM

Change #1031925 merged by jenkins-bot:

[mediawiki/extensions/Citoid@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031925

gerritbot added a comment.May 15 2024, 7:59 PM

Change #1031988 merged by jenkins-bot:

[mediawiki/extensions/SyntaxHighlight_GeSHi@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031988

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.6; 2024-05-21).May 15 2024, 8:00 PM
gerritbot added a comment.May 15 2024, 8:02 PM

Change #1031987 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031987

gerritbot added a comment.May 15 2024, 8:04 PM

Change #1031989 merged by jenkins-bot:

[mediawiki/extensions/Thanks@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031989

gerritbot added a comment.May 15 2024, 8:04 PM

Change #1031986 merged by jenkins-bot:

[mediawiki/extensions/Graph@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031986

gerritbot added a comment.May 15 2024, 8:04 PM

Change #1031990 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031990

gerritbot added a comment.May 15 2024, 8:05 PM

Change #1031994 merged by jenkins-bot:

[mediawiki/services/parsoid@master] eslint: remove redundant ruleset wikimedia/jsdoc

https://gerrit.wikimedia.org/r/1031994

Novem_Linguae mentioned this in rWSWFb879981e3812: eslint: remove redundant ruleset wikimedia/jsdoc.May 15 2024, 8:50 PM
Novem_Linguae mentioned this in rMSLNc160b75ac7d3: eslint: remove redundant ruleset wikimedia/jsdoc.May 15 2024, 11:11 PM
Novem_Linguae changed the task status from Open to Stalled.May 16 2024, 1:10 PM

Mostly done. There's one patch left, https://gerrit.wikimedia.org/r/c/mediawiki/services/service-scaffold-node/+/1031995, that is blocked on T365063: mediawiki/services/service-scaffold-node CI is broken.

gerritbot added a comment.May 20 2024, 5:26 PM

Change #1034127 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a5

https://gerrit.wikimedia.org/r/1034127

gerritbot added a comment.May 20 2024, 5:55 PM

Change #1034127 merged by jenkins-bot:

[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a5

https://gerrit.wikimedia.org/r/1034127

gerritbot added a comment.May 22 2024, 10:55 PM

Change #1031995 abandoned by Jforrester:

[mediawiki/services/service-scaffold-node@main] eslint: remove redundant ruleset wikimedia/jsdoc

Reason:

Archiving this repo; see https://phabricator.wikimedia.org/T365512

https://gerrit.wikimedia.org/r/1031995

Novem_Linguae closed this task as Resolved.May 26 2024, 9:36 AM
Novem_Linguae claimed this task.
Novem_Linguae removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL