Page MenuHomePhabricator
Create Task
Maniphest T365270

Table: improve readability in dark mode
Open, Needs TriagePublic
Actions

Description

Overview

The newly released Table component requires some improvements to work in dark mode, specifically the sortable column headers:

image.png (934×1 px, 106 KB)

Other Findings:

Light modeDark mode
Metric Platform - Table light mode.png (1×904 px, 148 KB)
Metric Platform - Table dark mode.png (1×900 px, 131 KB)

Acceptance Criteria

  • Ensure text and content within sortable column headers are readable.

Event Timeline

lwatson created this task.Fri, May 17, 4:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, May 17, 4:00 PM
AnneT subscribed.Mon, May 20, 4:09 PM

This seems to be specific to MPIC - they may not be including Codex dark mode styles yet. The Table generally looks ok in dark mode (check out the sandbox page), with the exception of sortable column headings:

image.png (934×1 px, 106 KB)

Maybe we should update this task to specifically cover that issue?

CCiufo-WMF moved this task from Inbox to Triaging on the Design-System-Team board.Tue, May 21, 5:22 PM
Volker_E added a project: Design.Tue, May 28, 10:39 PM
lwatson updated the task description. (Show Details)Fri, May 31, 2:10 PM

@AnneT I updated the task's acceptance criteria.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL