Page MenuHomePhabricator

Transaction fee (PTF) on Native form does not update with Amount
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Settings > Donate
  • Donate with ApplePay
  • Choose first amount ($3), then choose last suggested amount ($100)

What happens?:

  • Transaction fee remains the same at $0.35

What should have happened instead?:

(https://drive.google.com/file/d/1hAqiOGtYRxDoQ8Y2E5GGSg2MYVIxn4Uf/view?usp=sharing)

Reference

Event Timeline

HNordeenWMF moved this task from Needs Triage to Up next on the Wikipedia-iOS-App-Backlog board.

Hi! Opened up a pull request on this topic: https://github.com/wikimedia/wikipedia-ios/pull/4885
I've tried to alter the transactionFee method to calculate fee as 4% of donation. What do you think of that kind of solution, or is it supposed to be solved in terms of Combine? The opt string is still not updated with the fee, I am trying to get a grasp of how to fix it. I'd be happy to receive any feedback. Thanks

@Alevtina_Mashtaler I commented on the PR with some tips for fixing the opt string. Hope it helps!

@Alevtina_Mashtaler I have created a new PR here that builds on your work: https://github.com/wikimedia/wikipedia-ios/pull/4964. This will hopefully be merged this week. Thanks for your contribution!

Looks good to me - thank you @Alevtina_Mashtaler for your contributions to this task!