Page MenuHomePhabricator

TypeError: Argument 1 passed to MediaWiki\Output\OutputPage::parseInternal() must be of the type string, null given, called in /srv/mediawiki/php-1.43.0-wmf.6/includes/Output/OutputPage.php on line 2472
Closed, ResolvedPublic2 Estimated Story PointsPRODUCTION ERROR

Description

Error
labels.normalized_message
[{reqId}] {exception_url}   TypeError: Argument 1 passed to MediaWiki\Output\OutputPage::parseInternal() must be of the type string, null given, called in /srv/mediawiki/php-1.43.0-wmf.6/includes/Output/OutputPage.php on line 2472
error.stack_trace
from /srv/mediawiki/php-1.43.0-wmf.6/includes/Output/OutputPage.php(2511)
#0 /srv/mediawiki/php-1.43.0-wmf.6/includes/Output/OutputPage.php(2472): MediaWiki\Output\OutputPage->parseInternal(NULL, MediaWiki\Title\Title, boolean, boolean)
#1 /srv/mediawiki/php-1.43.0-wmf.6/extensions/Translate/src/TranslatorInterface/Aid/DocumentationAid.php(32): MediaWiki\Output\OutputPage->parseAsInterface(NULL)
#2 /srv/mediawiki/php-1.43.0-wmf.6/extensions/Translate/src/TranslatorInterface/Aid/TranslationAidsActionApi.php(111): MediaWiki\Extension\Translate\TranslatorInterface\Aid\DocumentationAid->getData()
#3 /srv/mediawiki/php-1.43.0-wmf.6/includes/api/ApiMain.php(1952): MediaWiki\Extension\Translate\TranslatorInterface\Aid\TranslationAidsActionApi->execute()
#4 /srv/mediawiki/php-1.43.0-wmf.6/includes/api/ApiMain.php(928): ApiMain->executeAction()
#5 /srv/mediawiki/php-1.43.0-wmf.6/includes/api/ApiMain.php(899): ApiMain->executeActionWithErrorHandling()
#6 /srv/mediawiki/php-1.43.0-wmf.6/includes/api/ApiEntryPoint.php(158): ApiMain->execute()
#7 /srv/mediawiki/php-1.43.0-wmf.6/includes/MediaWikiEntryPoint.php(200): MediaWiki\Api\ApiEntryPoint->execute()
#8 /srv/mediawiki/php-1.43.0-wmf.6/api.php(44): MediaWiki\MediaWikiEntryPoint->run()
#9 /srv/mediawiki/w/api.php(3): require(string)
#10 {main}
Impact
Notes

New issue in wmf.6

Details

MediaWiki Version
1.43.0-wmf.6
Request URL
https://www.mediawiki.org/w/api.php?action=translationaids&format=*&title=*&uselang=*

Event Timeline

Aklapper triaged this task as Unbreak Now! priority.May 21 2024, 9:51 AM
Aklapper created this task.
Nikerabbit set the point value for this task to 2.

Caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/999926/6/includes/Output/OutputPage.php#2512 aka rMWf61760614d57: [OutputPage] Hoist "null Title" checks up a level. Arguably should be fixed in Translate since type hint has been there but not enforced earlier.

Just noting that you might see failures in other places too.

Change #1034461 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/Translate@master] DocumentationAid: Fix fatal error

https://gerrit.wikimedia.org/r/1034461

Change #1034461 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] DocumentationAid: Fix fatal error

https://gerrit.wikimedia.org/r/1034461

Change #1034179 had a related patch set uploaded (by Aklapper; author: Nikerabbit):

[mediawiki/extensions/Translate@wmf/1.43.0-wmf.6] DocumentationAid: Fix fatal error

https://gerrit.wikimedia.org/r/1034179

Change #1034179 merged by jenkins-bot:

[mediawiki/extensions/Translate@wmf/1.43.0-wmf.6] DocumentationAid: Fix fatal error

https://gerrit.wikimedia.org/r/1034179

Mentioned in SAL (#wikimedia-operations) [2024-05-21T14:30:02Z] <aklapper@deploy1002> Started scap: Backport for [[gerrit:1034179|DocumentationAid: Fix fatal error (T365451)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-21T14:32:44Z] <aklapper@deploy1002> aklapper: Backport for [[gerrit:1034179|DocumentationAid: Fix fatal error (T365451)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-05-21T14:46:32Z] <aklapper@deploy1002> Finished scap: Backport for [[gerrit:1034179|DocumentationAid: Fix fatal error (T365451)]] (duration: 16m 30s)

Aklapper assigned this task to Nikerabbit.

Resolving - no errors in Logstash for this reqId after re-deploying wmf.6 to group0 with this patch backported. Thanks everyone!

This comment was removed by Aklapper.