Page MenuHomePhabricator

Fix padding between two rows
Closed, ResolvedPublicBUG REPORT

Assigned To
Authored By
Gopavasanth
May 24 2024, 5:10 PM
Referenced Files
F54372250: image.png
May 26 2024, 3:53 AM
F54343991: req.png
May 25 2024, 2:05 PM
F54343977: Made.png
May 25 2024, 2:05 PM
F54343952: before.png
May 25 2024, 2:05 PM
F54334743: image.png
May 25 2024, 9:51 AM
F54296963: image.png
May 24 2024, 5:10 PM
F54296957: image.png
May 24 2024, 5:10 PM

Description

Expected ImageCurrent Image
image.png (156×220 px, 10 KB)
image.png (1×918 px, 376 KB)

Related Objects

StatusSubtypeAssignedTask
OpenNone
ResolvedBUG REPORTKKsurendran06

Event Timeline

Thanks the Figma designed proved to be of great help, The following PR addresses the issue

Jayprakash12345 assigned this task to KKsurendran06.
Jayprakash12345 subscribed.

Thank you so much, @KKsurendran06. I have merged your PR. Once, @Gopavasanth comes back then he can merge these on GitLab.

Hi @KKsurendran06 , @Jayprakash12345.

I reviewed the PR, on reviewing the patch on my PC (Mac, 16-inch), the entire card position seems to be changed. Please take a look at the design changes once more.

image.png (2×3 px, 296 KB)

Interesting, it had passed the responsive test on my laptop. Let me find and fix this bug. Could you also test it and let me know if there are any other bugs or issues I might have caused by accident? This is my first time working with Vue.js, and I am very eager to improve.

@KKsurendran06 are you still able to work on the fixes? Just checking in on the progress

@KCVelaga, This issue was initially closed after I implemented the requested design changes, but it was reopened by Vasanth Gopa due to a responsive issue. However, it seems that the issue was resolved in the GitLab instance with this commit, so I believe this issue can now be closed as it has served its purpose.

I apologize for the delay in getting back to this. The Year in Review tool completely slipped out of my mind