Maniphest T365843

Fix padding between two rows
Open, Needs TriagePublicBUG REPORT
Actions

Assigned To

Authored By

	Gopavasanth
	Fri, May 24, 5:10 PM

Tags

Referenced Files

	F54372250: image.png
	Sun, May 26, 3:53 AM

	F54343991: req.png
	Sat, May 25, 2:05 PM

	F54343977: Made.png
	Sat, May 25, 2:05 PM

	F54343952: before.png
	Sat, May 25, 2:05 PM

	F54334743: image.png
	Sat, May 25, 9:51 AM

	F54296963: image.png
	Fri, May 24, 5:10 PM

	F54296957: image.png
	Fri, May 24, 5:10 PM

Subscribers

Jayprakash12345

View All 9 Subscribers

Description

Expected Image	Current Image

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T328385 "Year in Review" for Wikipedia Contributions
		Open	BUG REPORT	KKsurendran06	T365843 Fix padding between two rows

Event Timeline

Gopavasanth created this task.Fri, May 24, 5:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFri, May 24, 5:10 PM

KCVelaga moved this task from Backlog to Hack 2024 on the Indic-MediaWiki-Developers board.Fri, May 24, 5:34 PM

Alaka03aj subscribed.Sat, May 25, 6:01 AM

Totorono subscribed.Sat, May 25, 6:05 AM

KKsurendran06 subscribed.Sat, May 25, 6:18 AM

Swayam_Agrahari subscribed.Sat, May 25, 6:35 AM

DJ_M subscribed.Sat, May 25, 6:36 AM

Aakash2407 subscribed.Sat, May 25, 6:45 AM

Greedybad288 subscribed.Sat, May 25, 7:14 AM

Totorono moved this task from Hack 2024 to Backlog on the Indic-MediaWiki-Developers board.Sat, May 25, 7:39 AM

Greedybad288 moved this task from Backlog to Under discussion on the Indic-MediaWiki-Developers board.Sat, May 25, 7:40 AM

Greedybad288 moved this task from Bugs to In progress on the Tool-yearinreview board.Sat, May 25, 7:52 AM

Totorono moved this task from Under discussion to Indic-TechCom on the Indic-MediaWiki-Developers board.Sat, May 25, 8:47 AM

Totorono added a project: Indic-TechCom.

Greedybad288 moved this task from Indic-TechCom to Under discussion on the Indic-MediaWiki-Developers board.Sat, May 25, 8:47 AM

The expected image is not clear

Hi @KKsurendran06, here is the Figma link: https://www.figma.com/design/XXFIPYfmletBNoSg8xQsVo/Wikipedia-Year-in-Review?node-id=1-3&t=0HRUY5ZJ4LXheYMJ-1

Please raise a request to the same I'm happy to grant you access.

image.png (771×1 px, 313 KB)

Gopavasanth added a parent task: T328385: "Year in Review" for Wikipedia Contributions.Sat, May 25, 9:52 AM

KKsurendran06 added a comment.Sat, May 25, 1:37 PM

This comment was removed by KKsurendran06.

Thanks the Figma designed proved to be of great help, The following PR addresses the issue

Before{F54343952}

After{F54343977}

Requested{F54343991}

Thank you so much, @KKsurendran06. I have merged your PR. Once, @Gopavasanth comes back then he can merge these on GitLab.

Great, thanks !

Hi @KKsurendran06 , @Jayprakash12345.

I reviewed the PR, on reviewing the patch on my PC (Mac, 16-inch), the entire card position seems to be changed. Please take a look at the design changes once more.

image.png (2×3 px, 296 KB)

Interesting, it had passed the responsive test on my laptop. Let me find and fix this bug. Could you also test it and let me know if there are any other bugs or issues I might have caused by accident? This is my first time working with Vue.js, and I am very eager to improve.

Alaka03aj unsubscribed.Sun, May 26, 2:56 PM